4 New EC2 Instances with Recommended Configuration #476
+43
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Dec 13, 2024
source/s3_platform_info.c
Outdated
| .has_recommended_configuration = true, | ||
| }; | ||
|
|
||
| /***** End p4d.24xlarge and p4de.24xlarge ****/ | ||
|
|
||
| /***** Begin p5.48xlarge ******/ | ||
| /***** Begin p5_.48xlarge ******/ |
There was a problem hiding this comment.
what's with having both _ and . ?
There was a problem hiding this comment.
It's a section for the p5 family, so _ means p5+(e/en etc), and . is part of the instance name.
There was a problem hiding this comment.
I have gotten rid of _ since it was confusing and made the sections explicit.
source/s3_platform_info.c
Outdated
| .has_recommended_configuration = true, | ||
| }; | ||
| /***** End p5.48xlarge *****/ | ||
|
|
||
| /**** Begin trn2_48_large *****/ |
There was a problem hiding this comment.
trivial: why switch from . to _ in these comments? (this repeats again in the End comment)
| .instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("trn2.48xlarge"), | ||
| /* not all of the advertised 1600 Gbps bandwidth can be hit from the cpu in user-space */ | ||
| .max_throughput_gbps = 400, | ||
| .has_recommended_configuration = true, |
There was a problem hiding this comment.
need to coordinate with python teams on this...
graebm
approved these changes
Dec 13, 2024
|
We decided not to merge this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.