Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): separate concatenate node to sync and concatenate filter #84

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 15, 2023

Description

Apply following concatenate node change to sample sensor launch

This PR is useful for the multi-lidar occupancy gridmap creation.
related PR is #83.

image

Related links

Previous PR(closed):

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi requested review from yukkysaito and miursh December 15, 2023 15:43
@YoshiRi YoshiRi requested a review from soblin December 20, 2023 05:43
Copy link

stale bot commented Feb 18, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Feb 18, 2024
@stale stale bot removed the stale label Mar 8, 2024
Copy link

stale bot commented May 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label May 8, 2024
@YoshiRi YoshiRi marked this pull request as draft May 16, 2024 04:17
@stale stale bot removed the stale label May 16, 2024
Copy link

stale bot commented Jul 15, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant