Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new ground_segmentation filter #4443

Open
3 tasks done
yusufy1ld1z opened this issue Jul 28, 2023 · 7 comments
Open
3 tasks done

new ground_segmentation filter #4443

yusufy1ld1z opened this issue Jul 28, 2023 · 7 comments
Assignees
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@yusufy1ld1z
Copy link

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

There are many ground points in the output of the current ground filter. I have tried the algorithm accepted by RA-L with IROS'22 option named "TRAVEL: Traversable Ground and Above-Ground Object Segmentation using Graph Representation for 3D LiDAR Scans". The proposed algorithm is sensible and works better in accuracy and processing time than the scan_ground_filter. Due to the fact that this project is licensed with GPL-3.0, I am rewriting the code, making it more performant, and also adapting to Autoware stack by adding pointcloud_preprocessor, etc.
There is an comparison video of two algorithms :
https://youtu.be/VkzRjY9xLdk

Purpose

To give more precise output by the obstacle_segmentation/ground_filter with lowering the processing_time_ms.

Possible approaches

Adding the travel_ground_filter among the other filters as an option

Definition of done

  • Rewriting the code to license it with Apache-2.0
  • Adapt to Autoware stack and add some features like pointcloud_preprocessor
  • Adjust the launch files by including the new method
@ktro2828
Copy link
Contributor

ktro2828 commented Jul 28, 2023

Looks great! I'm actually implementing patchwork++ and I want to update it combining with TRAVEL. Therefore if you get any progress let's discuss about it!

https://github.com/ktro2828/autoware.universe/tree/feat/patchworkpp

@yusufy1ld1z
Copy link
Author

Thanks for your interest, excellent work!
I actually progressed quite much, I have written the implementation in the format of current ground filters, so I am working under the ground segmentation package rather than a distinct package because I am planning it to be an optional ground filter.

https://github.com/yusufy1ld1z/autoware.universe/tree/travel_ground_filter/perception/ground_segmentation

I will not be able to work on this project next week. I am waiting for your thoughts and future improvements with curiosity. After that, we can work together!

@badai-nguyen badai-nguyen added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 30, 2023
@ismetatabay ismetatabay added the type:new-feature New functionalities or additions, feature requests. label Aug 1, 2023
@stale
Copy link

stale bot commented Oct 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 1, 2023
@vividf
Copy link
Contributor

vividf commented Aug 27, 2024

@yusufy1ld1z
Hi, since there has been no update for this issue for a long time, I would like to ask what is the status of this. Thanks!

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Aug 27, 2024
@yusufy1ld1z
Copy link
Author

Hello again, apologies for a long break. I have not changed anything since the last update because I thought I already finished the project when I opened this issue. I think @ktro2828 has done a well job but I could not find the package of him after the last updates in the Autoware. If you still interested in my job I am ready to make updates you desire. Initially I adopted my project as an option to ground filters already in the perception ground segmentation stack and I am still agree with that. What are your further thoughts about the project, I am looking forward to open a PR !

@vividf
Copy link
Contributor

vividf commented Sep 5, 2024

@ktro2828 Do you have any idea about this?

Copy link

stale bot commented Nov 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 5, 2024
@amadeuszsz amadeuszsz moved this from In Progress to Backlog in Sensing & Perception Working Group Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
Status: Backlog
Development

No branches or pull requests

5 participants