Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Compat with numpy 2 and astropy 6.1 #1130

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

pllim
Copy link
Member

@pllim pllim commented Apr 5, 2024

Similar patch as astropy/astropy-healpix#215

Fix #1129

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (dac04ca) to head (e9762b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   72.21%   72.22%   +0.01%     
==========================================
  Files          62       62              
  Lines        4430     4432       +2     
==========================================
+ Hits         3199     3201       +2     
  Misses       1231     1231              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see green checks, thanks!

@rosteen rosteen merged commit 5ec4931 into astropy:main Apr 5, 2024
11 checks passed
@pllim pllim deleted the numpy-2-astropy-6.1-compat branch April 5, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy semantics change in numpy 2.0 caused incompatibility with astropy v6.1rc
2 participants