-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: fix compatibility with pytest 8 #820
Conversation
there was another warning specificly in oldest deps, which took a bit longer to inspect. I think I fixed it but I'll undraft only when CI is actually green everywhere |
0a87836
to
0f5b139
Compare
For context, I tracked the numpy deprecation warning down to astroscrappy. This was fixed upstream in astropy/astroscrappy@e5c12fa (first published in v1.1.0) I also threw in the |
0f5b139
to
eca268c
Compare
btw Python 3.11 and 3.12 are not tested at all. I'll add them to the test matrix in a follow up PR just in case it uncovers incompatibilities and I need to fix those too. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 9 9
Lines 1392 1392
=======================================
Hits 1358 1358
Misses 34 34 ☔ View full report in Codecov by Sentry. |
Thanks, @neutrinoceros! |
This should resolve the current CI instability. (example logs)
For context, what I think is happening is that the
pytest.warns
context manager's behavior was changed in pytest 8.0. In older versions, all warnings other than the one we were checking for were silently swallowed, and now they're not. In this specific test,astropy
would also emit someAstropyUserWarning
(s), which we don't control but are pointing to the very same problem we're testing for, so we should just filter them explicitly.