Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add CI coverage for Python 3.11 and 3.12 #822

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

neutrinoceros
Copy link
Contributor

Based off #820

@neutrinoceros neutrinoceros force-pushed the tst/py312 branch 2 times, most recently from 669f4ff to bc81cca Compare April 9, 2024 07:54
Comment on lines -91 to -94
python -c "import sys; print(f'Python {sys.version}')"
python -c "import pip; print(f'pip {pip.__version__}')"
python -c "import setuptools; print(f'setuptools {setuptools.__version__}')"
python -c "import tox; print(f'tox {tox.__version__}')"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason why I changed this is that, since Python 3.12.0, setuptools is not bundled with the standard lib, so this would crash. pip list is safer, less verbose, and gives even more information.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (b962f56) to head (c72a2e9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files           9        9           
  Lines        1392     1392           
=======================================
  Hits         1358     1358           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neutrinoceros
Copy link
Contributor Author

rebased on main

@neutrinoceros neutrinoceros marked this pull request as ready for review April 10, 2024 11:27
@mwcraig mwcraig merged commit 897dcaa into astropy:main Apr 11, 2024
15 checks passed
@neutrinoceros neutrinoceros deleted the tst/py312 branch April 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants