Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): static build might require zstd lib #4059

Merged
merged 3 commits into from
May 21, 2024
Merged

fix(build): static build might require zstd lib #4059

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e40109f
fix(build): static build might require zstd lib
geyslan May 21, 2024
656df9a
chore: install required bpftool from btfhub
geyslan May 21, 2024
ac9bdb1
chore: temp fix for install libzstd on AMIs
geyslan May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/e2e-install-deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,22 @@ remove_golang_os_packages() {
apt-get --purge autoremove -y
}

install_libzstd_os_packages() {
case $ID in
"ubuntu")
wait_for_apt_locks
apt-get install -y libzstd-dev
;;
"almalinux")
yum install -y libzstd-devel
;;
*)
echo "Unsupported OS: $ID"
exit 1
;;
esac
}

Comment on lines +267 to +282
Copy link
Member Author

@geyslan geyslan May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this would be unnecessary if we opted for an easier way of updating the AMIs bunch in a single shot. Anyway, after its future upgrade, those steps should be commented/removed.

# Main logic.

# Note: I left commented out the commands that would (re)install clang-14. This
Expand Down Expand Up @@ -328,3 +344,6 @@ if [[ $ID == "almalinux" ]]; then
remove_golang_usr_bin_files
install_golang_from_github
fi

# for static builds libelf might require libzstd
install_libzstd_os_packages
Loading