fix(build): static build might require zstd lib #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libelf might be built with zstd support in some environments, so for static builds (mainly) it is necessary to ensure that the zstd library is available. https://sourceware.org/git/?p=elfutils.git;a=commit;h=ed688a59b4d4f5ccf6ef15244e5a9139f71769a3
|
This would make room for aquasecurity/btfhub#117. |
|
https://github.com/aquasecurity/tracee/actions/runs/9166787615/job/25202867174?pr=4059
|
AMIs have to be updated and installations like this commented out.
geyslan
added
cherry-pick/v0.21.0
milestone/v0.21.0
and removed
cherry-pick/v0.21.0
labels
geyslan
commented
May 21, 2024
Comment on lines
+267
to
+282
| install_libzstd_os_packages() { | ||
| case $ID in | ||
| "ubuntu") | ||
| wait_for_apt_locks | ||
| apt-get install -y libzstd-dev | ||
| ;; | ||
| "almalinux") | ||
| yum install -y libzstd-devel | ||
| ;; | ||
| *) | ||
| echo "Unsupported OS: $ID" | ||
| exit 1 | ||
| ;; | ||
| esac | ||
| } | ||
|
|
There was a problem hiding this comment.
All this would be unnecessary if we opted for an easier way of updating the AMIs bunch in a single shot. Anyway, after its future upgrade, those steps should be commented/removed.
geyslan
commented
May 21, 2024
| @@ -95,7 +95,7 @@ Vagrant.configure("2") do |config| | |||
| ln -s "$path" "${path%-*}" | |||
| done | |||
|
|
|||
| apt-get install --yes zlib1g-dev libelf-dev | |||
| apt-get install --yes zlib1g-dev libelf-dev libzstd-dev | |||
There was a problem hiding this comment.
As we discussed @rscampos, the setup of the bpftool in Vagrantfile must be done in a further PR (since it requires a system upgrade). Thanks for noticing that. 👍🏼
There was a problem hiding this comment.
I'll upgrade Vagrantfile in order use compiled version of bpftool :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #4060
1. Explain what the PR does
ac9bdb1 chore: temp fix for install libzstd on AMIs
656df9a chore: install required bpftool from btfhub
e40109f fix(build): static build might require zstd lib
ac9bdb1 chore: temp fix for install libzstd on AMIs
e40109f fix(build): static build might require zstd lib
2. Explain how to test it
3. Other comments