Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subscriptions.mdx #7883

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Update subscriptions.mdx #7883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba83020
Update subscriptions.mdx
L-Qun May 30, 2024
e85e0cf
Update subscriptions.mdx
L-Qun May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/source/data/subscriptions.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ subscription PostFeed {
>
> The following steps assume you've already swapped to [`expressMiddleware`](../api/express-middleware).

To run both an Express app _and_ a separate WebSocket server for subscriptions, we'll create an `http.Server` instance that effectively wraps the two and becomes our new `listen`er.
To run both an Express app _and_ a separate WebSocket server for subscriptions, we'll create an `http.Server` instance that effectively wraps the two and becomes our new listener.

1. Install `graphql-ws`, `ws`, and `@graphql-tools/schema`:

Expand Down Expand Up @@ -127,7 +127,7 @@ To run both an Express app _and_ a separate WebSocket server for subscriptions,
});
```

7. Finally, ensure you are `listen`ing to your `httpServer`.
7. Finally, ensure you are listening to your `httpServer`.

Most Express applications call `app.listen(...)`, but for your setup change this to `httpServer.listen(...)` using the same arguments. This way, the server starts listening on the HTTP and WebSocket transports simultaneously.

Expand Down