Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscriptions.mdx #7883

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update subscriptions.mdx #7883

wants to merge 2 commits into from

Conversation

L-Qun
Copy link

@L-Qun L-Qun commented May 30, 2024

First, 🌠 thank you 🌠 for taking the time to consider a contribution to Apollo!

Here are some important details to follow:

  • ⏰ Your time is important
    To save your precious time, if the contribution you are making will take more
    than an hour, please make sure it has been discussed in an issue first.
    This is especially true for feature requests!
  • πŸ’‘ Features
    Feature requests can be created and discussed within a GitHub Issue. Be
    sure to search for existing feature requests (and related issues!) prior to
    opening a new request. If an existing issue covers the need, please upvote
    that issue by using the πŸ‘ emote, rather than opening a new issue.
  • πŸ”Œ Integrations
    Apollo Server has many web-framework integrations including Express, Koa,
    Hapi and more. When adding a new feature, or fixing a bug, please take a
    peak and see if other integrations are also affected. In most cases, the
    fix can be applied to the other frameworks as well. Please note that,
    since new web-frameworks have a high maintenance cost, pull-requests for
    new web-frameworks should be discussed with a project maintainer first.
  • πŸ•· Bug fixes
    These can be created and discussed in this repository. When fixing a bug,
    please try to add a test which verifies the fix. If you cannot, you should
    still submit the PR but we may still ask you (and help you!) to create a test.
  • πŸ“– Contribution guidelines
    Follow https://github.com/apollographql/apollo-server/blob/main/CONTRIBUTING.md
    when submitting a pull request. Make sure existing tests still pass, and add
    tests for all new behavior.
  • ✏️ Explain your pull request
    Describe the big picture of your changes here to communicate to what your
    pull request is meant to accomplish. Provide πŸ”— links πŸ”— to associated issues!

We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment.

@L-Qun L-Qun requested review from glasser, trevor-scheer and a team as code owners May 30, 2024 12:10
@apollo-cla
Copy link

@L-Qun: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented May 30, 2024

πŸ‘· Deploy request for apollo-server-docs pending review.

Visit the deploys page to approve it

Name Link
πŸ”¨ Latest commit e85e0cf

Copy link

codesandbox-ci bot commented May 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants