Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve request specs #56

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Improve request specs #56

merged 3 commits into from
Dec 16, 2023

Commits on Dec 16, 2023

  1. Fix Router signature

    @apexatoll
    apexatoll committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    793aa77 View commit details
    Browse the repository at this point in the history

  2. Do not cache Router#controller_class 

    - This was causing issues in request specs in target applications, in
  that making a request to a controller after initially making a request
  to another controller was failing
- Caching the controller_class meant that the initial controller was
  attempted to be used for both requests
    @apexatoll
    apexatoll committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    06a14a6 View commit details
    Browse the repository at this point in the history

  3. Opt in to stubbing request spec output 

    - This was difficult to debug
    @apexatoll
    apexatoll committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    334fea8 View commit details
    Browse the repository at this point in the history