Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve request specs #56

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Improve request specs #56

merged 3 commits into from
Dec 16, 2023

Conversation

apexatoll
Copy link
Owner

  • Do not cache Router#controller_class

    • This was causing issues in request specs in target applications, in that making a request to a controller after initially making a request to another controller was failing
    • Caching the controller_class meant that the initial controller was attempted to be used for both requests

  • Opt in to stubbing request spec output

    • This was difficult to debug

@apexatoll
Fix Router signature
793aa77
@apexatoll
Do not cache Router#controller_class
06a14a6 
- This was causing issues in request specs in target applications, in
  that making a request to a controller after initially making a request
  to another controller was failing
- Caching the controller_class meant that the initial controller was
  attempted to be used for both requests
@apexatoll
Opt in to stubbing request spec output
334fea8 
- This was difficult to debug
@apexatoll apexatoll merged commit bd7a038 into main Dec 16, 2023
3 checks passed
@apexatoll apexatoll deleted the fix-router-idempotency branch December 16, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apexatoll