Issue #259: Confusing label "Total Stars" changed to "Stars Gained" #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 16 16
Lines 490 490
Branches 130 130
=======================================
Hits 462 462
Misses 24 24
Partials 4 4
Continue to review full report at Codecov.
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in the PR are related to issue #259.
As per the conversation in above issue, this issue was raised number of times (#69, #170, #39), which clearly indicates that the label is confusing so I have changed the label as discussed to the best way I can.
Happy to change to a meaningful label, but "Stars Gained" is the best I could do.