Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-capitalised stars stat text #1285

Closed
wants to merge 1 commit into from
Closed

Fix non-capitalised stars stat text #1285

wants to merge 1 commit into from

Conversation

louislefevre
Copy link

@louislefevre louislefevre commented Sep 2, 2021

The changes from commit d790404 failed to capitalise the text for the total stars stat. This ruins consistency compared to the text from other stats, and makes it look out of place.

@vercel
Copy link

vercel bot commented Sep 2, 2021

@louislefevre is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the card-i18n Card text translations. label Sep 2, 2021
@louislefevre louislefevre changed the title Capitalise English stars text Fix non-capitalised stars stat text Sep 2, 2021
@FayasNoushad
Copy link
Contributor

Total Stars Recieved is too long in the stats. Total Stars is best.

@louislefevre
Copy link
Author

Total Stars Recieved is too long in the stats. Total Stars is best.

I agree with this as well, though wasn't sure if @anuraghazra would want to revert that change.

@louislefevre
Copy link
Author

Fixed in 98ceb75

@anuraghazra
Copy link
Owner

anuraghazra commented Sep 6, 2021

Hi @louislefevre I've made it to "Total Stars Earned"

Even I like the simple "Total Stars" but I have to agree that it can be confusing which stats it is referring to. Lot of people are also getting confused with the wording thus I changed it in #1293

ref #282 #39

@FayasNoushad
Copy link
Contributor

Hi @louislefevre I've made it to "Total Stars Earned"

Even I like the simple "Total Stars" but I have to agree that it can be confusing which stats it is referring to. Lot of people are also getting confused with the wording thus I changed it in #1293

ref #282 #39

Nice 👍

@FayasNoushad
Copy link
Contributor

@anuraghazra Please merge #1163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
card-i18n Card text translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants