Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finer ranking levels #2762

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Add finer ranking levels #2762

merged 2 commits into from
Jun 12, 2023

Conversation

francois-rozet
Copy link
Collaborator

@francois-rozet francois-rozet commented Jun 1, 2023

This PR removes the S+ rank (to comply with the Japanese grading system) and adds finer ranking levels (now S, A+, A, A-, B+, B, B-, C+ and C).

I also used a different cumulative distribution function (CDF) for stars and followers. The distributions of these two stats have heavier tails (meaning that large values are more likely) than what an exponential distribution allows. So instead I used an approximation of the log-normal CDF. This makes the initial ranks (C to A) more accessible, but the final rank (S) extremely hard to reach.

I also replaced the word score by percentile.

@vercel
Copy link

vercel bot commented Jun 1, 2023

@francois-rozet is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.27 🎉

Comparison is base (e0b3d83) 97.32% compared to head (65182a2) 97.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2762      +/-   ##
==========================================
+ Coverage   97.32%   97.59%   +0.27%     
==========================================
  Files          24       24              
  Lines        4742     4824      +82     
  Branches      431      448      +17     
==========================================
+ Hits         4615     4708      +93     
+ Misses        126      115      -11     
  Partials        1        1              
Impacted Files Coverage Δ
src/calculateRank.js 100.00% <100.00%> (ø)
src/cards/stats-card.js 100.00% <100.00%> (ø)
src/fetchers/stats-fetcher.js 92.63% <100.00%> (+0.87%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This was referenced Jun 2, 2023
@rickstaa
Copy link
Collaborator

rickstaa commented Jun 2, 2023

Normal

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=torvalds)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=rickstaa)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=anuraghazra)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=francois-rozet)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=FleetAdmiralJakob)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=objektwerks)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=meurissemax)

include_all_commits=true

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=torvalds&include_all_commits=true)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=anuraghazra&include_all_commits=true)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=rickstaa&include_all_commits=true)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=francois-rozet&include_all_commits=true)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=FleetAdmiralJakob&include_all_commits=true)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=objektwerks&include_all_commits=true)

![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=meurissemax&include_all_commits=true)

@rickstaa
Copy link
Collaborator

rickstaa commented Jun 2, 2023

Damn, I love it ❤️‍🔥! @francois-rozet I think you did an outstanding job! Will review this weekend 👍🏻.

@rickstaa
Copy link
Collaborator

rickstaa commented Jun 2, 2023

@francois-rozet I already checked the PR. Maybe you can merge #2749 into this PR and update it to the new ranking mechanism?

@francois-rozet
Copy link
Collaborator Author

Sure!

@rickstaa
Copy link
Collaborator

rickstaa commented Jun 3, 2023

Sure!

Amazing! Based on all the work you did for this repository, I asked @anuraghazra to invite you as a collaborator. You are welcome to accept or decline based on whether you have the time available. In any case, thanks again for tackling the ranking issue 🙏🏻.

@francois-rozet
Copy link
Collaborator Author

francois-rozet commented Jun 5, 2023

Sorry I have a really busy week, I'll do this as soon as possible.

Thank you for the kind words, that's an honor 😁

@rickstaa
Copy link
Collaborator

rickstaa commented Jun 5, 2023

Sorry I have a really busy week, I'll do this as soon as possible.

Thank you for the kind words, that's an honor grin

Ha, no problem, take your time. We received many positive reactions after your last pull request was merged 👍🏻.

@github-actions github-actions bot added documentation Improvements or additions to documentation. ranks Feature, Bug fix, improvement related to ranking system. stats-card Feature, Enhancement, Fixes related to stats the stats card. labels Jun 12, 2023
@francois-rozet
Copy link
Collaborator Author

francois-rozet commented Jun 12, 2023

@rickstaa I Just updated the description!

@rickstaa rickstaa merged commit 66e5492 into anuraghazra:master Jun 12, 2023
@rickstaa
Copy link
Collaborator

Great thanks! Merged into master 🚀.

@francois-rozet francois-rozet deleted the rank branch June 12, 2023 12:45
rickstaa added a commit that referenced this pull request Jun 13, 2023
This commit ensures the new rank values introduced by #2762 are added
to the 2e2 test.
qwerty541 pushed a commit that referenced this pull request Jun 13, 2023
This commit ensures the new rank values introduced by #2762 are added
to the 2e2 test.
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
* Add finer ranking levels

* Update rank description
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
This commit ensures the new rank values introduced by anuraghazra#2762 are added
to the 2e2 test.
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
* Add finer ranking levels

* Update rank description
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
This commit ensures the new rank values introduced by anuraghazra#2762 are added
to the 2e2 test.
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this pull request Nov 6, 2024
* Add finer ranking levels

* Update rank description
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this pull request Nov 6, 2024
This commit ensures the new rank values introduced by anuraghazra#2762 are added
to the 2e2 test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. ranks Feature, Bug fix, improvement related to ranking system. stats-card Feature, Enhancement, Fixes related to stats the stats card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants