-
-
Notifications
You must be signed in to change notification settings - Fork 23.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add finer ranking levels #2762
Add finer ranking levels #2762
Conversation
@francois-rozet is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2762 +/- ##
==========================================
+ Coverage 97.32% 97.59% +0.27%
==========================================
Files 24 24
Lines 4742 4824 +82
Branches 431 448 +17
==========================================
+ Hits 4615 4708 +93
+ Misses 126 115 -11
Partials 1 1
☔ View full report in Codecov by Sentry. |
Normal![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=torvalds) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=rickstaa) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=anuraghazra) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=francois-rozet) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=FleetAdmiralJakob) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=objektwerks) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=meurissemax) include_all_commits=true![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=torvalds&include_all_commits=true) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=anuraghazra&include_all_commits=true) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=rickstaa&include_all_commits=true) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=francois-rozet&include_all_commits=true) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=FleetAdmiralJakob&include_all_commits=true) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=objektwerks&include_all_commits=true) ![](https://github-readme-stats-git-rank-rickstaa.vercel.app/api?username=meurissemax&include_all_commits=true) |
Damn, I love it ❤️🔥! @francois-rozet I think you did an outstanding job! Will review this weekend 👍🏻. |
@francois-rozet I already checked the PR. Maybe you can merge #2749 into this PR and update it to the new ranking mechanism? |
Sure! |
Amazing! Based on all the work you did for this repository, I asked @anuraghazra to invite you as a collaborator. You are welcome to accept or decline based on whether you have the time available. In any case, thanks again for tackling the ranking issue 🙏🏻. |
Sorry I have a really busy week, I'll do this as soon as possible.
|
Ha, no problem, take your time. We received many positive reactions after your last pull request was merged 👍🏻. |
@rickstaa I Just updated the description! |
Great thanks! Merged into master 🚀. |
This commit ensures the new rank values introduced by #2762 are added to the 2e2 test.
This commit ensures the new rank values introduced by #2762 are added to the 2e2 test.
* Add finer ranking levels * Update rank description
This commit ensures the new rank values introduced by anuraghazra#2762 are added to the 2e2 test.
* Add finer ranking levels * Update rank description
This commit ensures the new rank values introduced by anuraghazra#2762 are added to the 2e2 test.
* Add finer ranking levels * Update rank description
This commit ensures the new rank values introduced by anuraghazra#2762 are added to the 2e2 test.
This PR removes the S+ rank (to comply with the Japanese grading system) and adds finer ranking levels (now S, A+, A, A-, B+, B, B-, C+ and C).
I also used a different cumulative distribution function (CDF) for stars and followers. The distributions of these two stats have heavier tails (meaning that large values are more likely) than what an exponential distribution allows. So instead I used an approximation of the log-normal CDF. This makes the initial ranks (C to A) more accessible, but the final rank (S) extremely hard to reach.
I also replaced the word
score
bypercentile
.