Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early sapling balance check #3439

Merged
merged 40 commits into from
Jul 5, 2024

Extracts the sapling value balance directly in `validate_transparent_…

a3bb632
Select commit
Loading
Failed to load commit list.
Merged

Early sapling balance check #3439

Extracts the sapling value balance directly in `validate_transparent_…
a3bb632
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 1, 2024 in 0s

53.51% (-0.41%) compared to 879a326

View this Pull Request on Codecov

53.51% (-0.41%) compared to 879a326

Details

Codecov Report

Attention: Patch coverage is 26.50288% with 1406 lines in your changes missing coverage. Please review.

Project coverage is 53.51%. Comparing base (879a326) to head (a3bb632).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp.rs 0.00% 572 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 293 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 134 Missing ⚠️
crates/apps_lib/src/cli.rs 0.00% 110 Missing ⚠️
crates/namada/src/ledger/protocol/mod.rs 77.65% 78 Missing ⚠️
crates/light_sdk/src/transaction/transfer.rs 0.00% 32 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 31 Missing ⚠️
crates/token/src/lib.rs 0.00% 26 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 24 Missing ⚠️
crates/state/src/wl_state.rs 58.82% 21 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3439      +/-   ##
==========================================
- Coverage   53.92%   53.51%   -0.41%     
==========================================
  Files         317      317              
  Lines      107575   108647    +1072     
==========================================
+ Hits        58011    58147     +136     
- Misses      49564    50500     +936     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.