Early sapling balance check #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
==========================================
- Coverage 53.92% 53.51% -0.41%
==========================================
Files 317 317
Lines 107575 108647 +1072
==========================================
+ Hits 58011 58147 +136
- Misses 49564 50500 +936 ☔ View full report in Codecov by Sentry. |
murisi
reviewed
Jun 25, 2024
murisi
approved these changes
Jun 25, 2024
Closed
brentstone
added a commit
that referenced
this pull request
Jun 28, 2024
* grarco/early-sapling-balance-check: Extracts the sapling value balance directly in `validate_transparent_bundle` Changelog #2721 Early sapling balance check in masp vp
brentstone
added a commit
that referenced
this pull request
Jul 4, 2024
* origin/grarco/early-sapling-balance-check: Extracts the sapling value balance directly in `validate_transparent_bundle` Changelog #2721 Early sapling balance check in masp vp
brentstone
added a commit
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2721.
Moves the check on the sapling value balance slightly up in the masp vp to reject invalid transactions earlier.
Indicate on which release or other PRs this topic is based on
#3393 (diffs for review: https://github.com/anoma/namada/pull/3439/files/13b4bcd098d0288c11c90088c6a7b106818f76a8..a3bb632a1f40700abae9027a80cc9fcd88725f70)
Checklist before merging to
draft