Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/draft with masp ibc replay protection #3430

Closed
wants to merge 78 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
e02fe43
Now hash the TransferTarget into Transaction transparent outputs.
murisi May 28, 2024
6cbe813
Modified the MASP VP to check the IBC receivers.
murisi May 31, 2024
20d113b
Created a separate type that is either an Address or IBC receiver.
murisi Jun 1, 2024
031ba8a
empty commit
brentstone Jun 6, 2024
6daeaf7
Increase disposable key lifetime
sug0 Jun 6, 2024
e147d7a
Changelog for #3378
sug0 Jun 6, 2024
ca10451
Add block header Namada rpc handler
sug0 Jun 4, 2024
493e453
Implement date time subtraction
sug0 Jun 4, 2024
3cca791
Read epochs per year param
sug0 Jun 4, 2024
93112ea
Add max block duration estimate rpc method
sug0 Jun 4, 2024
64d974d
Retrieve max block time estimate from new rpc method in masp
sug0 Jun 4, 2024
acd92ee
use the new smooth-operator checked assign ops
tzemanovic Jun 5, 2024
183aa61
changelog: add #3374
tzemanovic Jun 5, 2024
743c154
remove check for maximum number of signatures per tx
brentstone Jun 6, 2024
dc23750
changelog: add #3380
brentstone Jun 6, 2024
8bb9f8c
Remove max expected block time param
sug0 Jun 4, 2024
7481d60
Split out `estimate_max_block_time_from_parameters`
sug0 Jun 4, 2024
6b71302
Insert mock block headers into test storage
sug0 Jun 5, 2024
996c48e
Test max block time estimates
sug0 Jun 5, 2024
beadc81
Avoid estimating block time of zero
sug0 Jun 5, 2024
eebf5d9
Import `namada_storage` with `testing` feat
sug0 Jun 5, 2024
2164904
Add additional test coverage for max expected block times
sug0 Jun 6, 2024
e9f5a46
Vectorizes transparent transfers
grarco Jun 2, 2024
36e215b
Vectorizes masp transfers
grarco Jun 3, 2024
3eff3b4
Fixes benchmarks
grarco Jun 3, 2024
453b211
Fixes signature generation for vectorized transfers
grarco Jun 4, 2024
4a94e0e
Check no vectorized transfers in cli
grarco Jun 6, 2024
9d6c19d
Misc improvements to signing for vectorized transfers
grarco Jun 6, 2024
561e4e8
Avoids reloading shielded context
grarco Jun 6, 2024
dd3f19a
shielded_token: store the total rewards minted by MASP
tzemanovic Jun 5, 2024
6d4ff88
sdk: add a query for MASP total rewards
tzemanovic Jun 5, 2024
054f915
client/rpc: print MASP total rewards in conversions query
tzemanovic Jun 5, 2024
3a77b4a
Fmt
grarco Jun 6, 2024
1e98403
Changelog #3356
grarco Jun 4, 2024
9b8aba6
cli: add shell completions generator
tzemanovic May 31, 2024
d776ff2
changelog: add #3343
tzemanovic May 31, 2024
75a2fdc
update Cargo.lock
brentstone Jun 6, 2024
6cfe4c6
Merge branch 'tomas/checked-assign-ops' (#3374)
brentstone Jun 6, 2024
575cb0e
Merge branch 'tiago/increase-disposable-key-lifetime' (#3378)
brentstone Jun 6, 2024
dcdc548
Merge branch 'tomas/shell-complete' (#3343)
brentstone Jun 6, 2024
b0f851f
changelog: add #3375
tzemanovic Jun 6, 2024
a0d05e6
empty commit
brentstone Jun 6, 2024
8bc54e5
Merge branch 'brent/remove-max-sigs' (#3380)
brentstone Jun 7, 2024
2b49dc0
Now check that the IBC events are valid with respect to storage changes.
murisi Jun 4, 2024
4582437
remove epoch multipler check for governance
Fraccaman Jun 7, 2024
7368256
Merge branch 'grarco/vectorize-transfers' (#3356)
brentstone Jun 7, 2024
95c1e96
minors
Fraccaman Jun 7, 2024
c2a200a
minors
Fraccaman Jun 7, 2024
e6e9ba1
Merge branch 'tomas/masp-total-rewards' (#3375)
brentstone Jun 7, 2024
abbf3b2
Split up the IBC validation logic in MASP.
murisi Jun 7, 2024
4980b18
some small changes
brentstone Jun 8, 2024
04ac10e
changelog: add #3390
brentstone Jun 9, 2024
2039931
Merge branch 'fraccaman/remove-multipler-check-governance' (#3390)
brentstone Jun 10, 2024
ed45335
Remove redundant TODO
sug0 Jun 11, 2024
b55f5bc
Centralized the construction of TransparentAddresses to ensure that e…
murisi Jun 11, 2024
0963ec3
Test inner tx results from batch tx
sug0 Jun 11, 2024
486e404
Changelog for #3401
sug0 Jun 11, 2024
5547f09
Handle the is_sender_chain_source case in the MASP VP.
murisi Jun 11, 2024
423ee7f
Ensure that native tokens can always be decoded.
murisi Jun 12, 2024
0ae6f2b
Reduced the dependence on IBC events.
murisi Jun 12, 2024
438a4ab
Merge branch 'base' into murisi/masp-ibc-replay-protection-using-txda…
murisi Jun 12, 2024
2434e73
update Hermes
yito88 Jun 6, 2024
c4d788d
Decrease max block time estimate to 1m
sug0 Jun 13, 2024
db67411
Clue IBC max block time estimate from Namada params
sug0 Jun 13, 2024
17adaeb
Adjust IBC timeout values
sug0 Jun 13, 2024
48f58aa
Changelog for #3366
sug0 Jun 5, 2024
08e5664
Subdivided some functions involved in processing IBC packets.
murisi Jun 14, 2024
8c2520e
Merge branch 'tiago/test-batch-tx-events' (#3401)
brentstone Jun 14, 2024
62ab4db
Merge branch 'tiago/remove-max-block-time-param' (#3366)
brentstone Jun 14, 2024
a2854e7
Now map denominations to tokens using ibc_token instead of reverse_qu…
murisi Jun 19, 2024
6739f0b
Removed is_any_shielded_action_balance_key and related code since tha…
murisi Jun 19, 2024
18fe989
Simplify checking packet acknowledgement by assuming the uniqueness o…
murisi Jun 19, 2024
8de2ec0
Added more comments and improved function naming.
murisi Jun 19, 2024
0c999bd
Start using IBC ports to determine message formats.
murisi Jun 19, 2024
d0b4f3d
Now charge gas in IBC denom query.
murisi Jun 19, 2024
0a5d480
Update balances in the MASP using a non-mutating style.
murisi Jun 19, 2024
7ff94bd
Added changelog entry.
murisi Jun 20, 2024
76fab4c
Merge branch 'murisi/masp-ibc-replay-protection-using-txdata-on-0.39.…
murisi Jun 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/3375-masp-total-rewards.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Update native token total supply with MASP rewards.
([\#3375](https://github.com/anoma/namada/pull/3375))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Increase the lifetime of disposable signing keys from 5 minutes to 1 week.
([\#3378](https://github.com/anoma/namada/pull/3378))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Add replay protection to MASP-IBC transactions.
([\#3409](https://github.com/anoma/namada/pull/3409))
2 changes: 2 additions & 0 deletions .changelog/unreleased/features/3356-vectorize-transfers.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Reworked transparent and masp transfers to allow for multiple sources, targets,
tokens and amounts. ([\#3356](https://github.com/anoma/namada/pull/3356))
11 changes: 11 additions & 0 deletions .changelog/unreleased/improvements/3343-shell-complete.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
- Added a `namada complete` command to generate shell completions. This command
requires `--shell` with one of:
- bash
- elvish
- fish
- powershell
- zsh
- nushell

To use in e.g. bash, run `namada complete --shell bash > /usr/share/bash-completion/completions/namada.bash`.
([\#3343](https://github.com/anoma/namada/pull/3343))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Remove the `max_expected_time_per_block` genesis parameter.
([\#3366](https://github.com/anoma/namada/pull/3366))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/3374-checked-assign-ops.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Refactored checked assign arithmetic operations to use smooth-operator macro.
([\#3374](https://github.com/anoma/namada/pull/3374))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/3375-masp-total-rewards.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Store total MASP rewards and print them in the conversions query.
([\#3375](https://github.com/anoma/namada/pull/3375))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/3380-remove-max-sigs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Remove the check on the maximum number of signatures allowed per transaction
([\#3380](https://github.com/anoma/namada/pull/3380))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Remove the requirement that the proposal voting period
is some integer multiple of the minimum voting period.
([\#3390](https://github.com/anoma/namada/pull/3390))
3 changes: 3 additions & 0 deletions .changelog/unreleased/testing/3401-test-batch-tx-events.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Adds additional test coverage to batch tx events emission, to make
sure we correctly build a batch of inner tx events from a batched tx.
([\#3401](https://github.com/anoma/namada/pull/3401))
2 changes: 1 addition & 1 deletion .github/workflows/scripts/hermes.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.8.2-namada-beta11-rc2
1.8.2-namada-beta12-rc
Loading
Loading