Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/draft with masp ibc replay protection #3430

Closed
wants to merge 78 commits into from

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Jun 20, 2024

Describe your changes

Checking the combination of #3409 and #3377 .

Indicate on which release or other PRs this topic is based on

#3409
#3377

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

brentstone and others added 24 commits June 10, 2024 08:54
* fraccaman/remove-multipler-check-governance:
  changelog: add #3390
  some small changes
  minors
  minors
  remove epoch multipler check for governance
* tiago/test-batch-tx-events:
  Changelog for #3401
  Test inner tx results from batch tx
  Remove redundant TODO
* tiago/remove-max-block-time-param:
  Changelog for #3366
  Adjust IBC timeout values
  Clue IBC max block time estimate from Namada params
  Decrease max block time estimate to 1m
  update Hermes
  Add additional test coverage for max expected block times
  Import `namada_storage` with `testing` feat
  Avoid estimating block time of zero
  Test max block time estimates
  Insert mock block headers into test storage
  Split out `estimate_max_block_time_from_parameters`
  Remove max expected block time param
  Retrieve max block time estimate from new rpc method in masp
  Add max block duration estimate rpc method
  Read epochs per year param
  Implement date time subtraction
  Add block header Namada rpc handler
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 25.60554% with 1290 lines in your changes missing coverage. Please review.

Project coverage is 53.66%. Comparing base (879a326) to head (76fab4c).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/namada/src/ledger/native_vp/masp.rs 0.00% 285 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 220 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 188 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 134 Missing ⚠️
crates/apps_lib/src/cli.rs 0.00% 115 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 49 Missing ⚠️
crates/core/src/masp.rs 0.00% 41 Missing ⚠️
crates/sdk/src/args.rs 0.00% 33 Missing ⚠️
crates/light_sdk/src/transaction/transfer.rs 0.00% 30 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 27 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
- Coverage   53.92%   53.66%   -0.26%     
==========================================
  Files         317      317              
  Lines      107575   108411     +836     
==========================================
+ Hits        58011    58180     +169     
- Misses      49564    50231     +667     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi force-pushed the murisi/draft-with-masp-ibc-replay-protection branch from 8e8d046 to 808a950 Compare June 20, 2024 17:52
@murisi murisi force-pushed the murisi/draft-with-masp-ibc-replay-protection branch from 808a950 to 76fab4c Compare June 20, 2024 18:53
@brentstone brentstone closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants