fix: Adjusting Tag display to handle long tag names #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdslaugh
requested review from
Golodhros,
ttannis,
allisonsuarez,
feng-tao,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma,
kristenarmes,
ozandogrultan and
B-T-D
as code owners
Signed-off-by: Josh Slaughter <[email protected]>
jdslaugh
force-pushed
the
tag-overflow-adjustment
branch
from
2f2e36e
to
0078821
Compare
Signed-off-by: Josh Slaughter <[email protected]>
kristenarmes
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found that there were some visual inconsistencies when dealing with long tag names. Handled the overflow with the layout and set
max-widthfor the button to utilize the default overflow handling. Added titles to allow for accessibility.Motivation and Context
To provide a better user experience.
How Has This Been Tested?
Locally with mock data to force long tag names
Screenshots
Before
After
After (w/Title)
CheckList