Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjusting Tag display to handle long tag names #2271

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix: Adjusting Tag display to handle long tag names #2271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0078821
fix: Adjusting Tag display to handle long tag names
jdslaugh Oct 14, 2024
8d81531
Adding type to button to fix eslint error
jdslaugh Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions frontend/amundsen_application/static/.betterer.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ exports[`eslint`] = {
[83, 6, 13, "Do not use setState in componentDidUpdate", "57229240"],
[101, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
],
"js/components/OwnerEditor/index.tsx:2385247435": [
[85, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
"js/components/OwnerEditor/index.tsx:2842129076": [
[88, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
],
"js/components/Preloader/index.tsx:958787996": [
[22, 4, 26, "Must use destructuring props assignment", "1492876559"],
Expand Down Expand Up @@ -76,14 +76,13 @@ exports[`eslint`] = {
"js/features/SearchBar/index.tsx:2560837631": [
[84, 2, 51, "refToSelf should be placed before constructor", "3412474606"]
],
"js/features/Tags/TagInput/index.tsx:914140200": [
"js/features/Tags/TagInput/index.tsx:896029978": [
[107, 19, 2, "Array.prototype.map() expects a return value from arrow function.", "5859494"],
[172, 2, 801, "onChange should be placed before noOptionsMessage", "331725852"],
[186, 8, 21, "Must use destructuring props assignment", "2890513821"],
[190, 6, 21, "Must use destructuring props assignment", "2890513821"],
[238, 8, 118, "Visible, non-interactive elements with click handlers must have at least one keyboard listener.", "3772713652"],
[238, 8, 118, "Static HTML elements with event handlers require a role.", "3772713652"],
[310, 10, 203, "Missing an explicit type attribute for button", "893477908"]
[238, 8, 118, "Static HTML elements with event handlers require a role.", "3772713652"]
],
"js/pages/DashboardPage/ChartList/index.tsx:305174342": [
[11, 0, 446, "Component should be written as a pure function", "2708651446"]
Expand Down
2 changes: 2 additions & 0 deletions frontend/amundsen_application/static/css/_layouts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,11 +241,13 @@ $close-btn-size: 24px;
flex-basis: $inner-column-size;
flex-direction: column;
margin-right: 12px;
min-width: 0;
}

> .right-column {
flex-basis: $inner-column-size;
margin-left: 12px;
min-width: 0;
}
}

Expand Down
1 change: 1 addition & 0 deletions frontend/amundsen_application/static/js/features/Tags/TagInfo/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export class TagInfo extends React.Component<TagInfoProps> {
className={'btn tag-button' + (compact ? ' compact' : '')}
type="button"
onClick={this.onClick}
title={name}
>
<span className="tag-name">{name}</span>
{!compact && <span className="tag-count">{data.tag_count}</span>}
Expand Down
1 change: 1 addition & 0 deletions frontend/amundsen_application/static/js/features/Tags/TagInfo/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
padding: 8px;
text-overflow: ellipsis;
white-space: nowrap;
max-width: 100%;

&.compact {
height: 30px;
Expand Down
2 changes: 2 additions & 0 deletions frontend/amundsen_application/static/js/features/Tags/TagInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,8 @@ export class TagInput extends React.Component<TagInputProps, TagInputState> {
<button
className="btn btn-default muted add-btn"
onClick={this.startEditing}
title="New"
type="button"
>
<img className="icon icon-plus" alt="" />
New
Expand Down
Loading