Added Telugu Language. #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-jn
reviewed
Oct 31, 2020
src/main/res/values-te/strings.xml
Outdated
| @@ -0,0 +1,191 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <resources> | |||
| <string name = "alert_delete_confirm"> మీకు ఖచ్చితంగా తెలుసా? </ string> | |||
There was a problem hiding this comment.
Please remove extra space before and after each entry. Use refactoring in Android studio
|
Resolved the issues. kindly respond quickly as hacktoberfest is closing in few hours. |
|
@asaikarthikeya The travis build still fails. Please check that first. |
Fixed XML formatting issues.
Fixed changes in values-te/strings.xml |
chirag-jn
reviewed
Nov 1, 2020
src/main/res/values-bn/strings.xml
Outdated
| @@ -43,6 +43,7 @@ | |||
| <string name="language_fr">ফ্রেঞ্চ</string> | |||
| <string name="language_es">স্প্যানিশ</string> | |||
| <string name="language_bn">বাংলা</string> | |||
| <string name="language_te">తెలుగు</string> | |||
There was a problem hiding this comment.
This doesn't match the Google Translation. Probably @Ayan-10 can help here?
Remove duplicate entries
|
This PR is a step towards #548 |
|
Yes. It should be written as তেলেগু instead of తెలుగు
…On Sun, 1 Nov 2020, 1:26 p.m. Chirag Jain, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/res/values-bn/strings.xml
<#681 (comment)>:
> @@ -43,6 +43,7 @@
<string name="language_fr">ফ্রেঞ্চ</string>
<string name="language_es">স্প্যানিশ</string>
<string name="language_bn">বাংলা</string>
+ <string name="language_te">తెలుగు</string>
This doesn't match the Google Translation. Probably @Ayan-10
<https://github.com/Ayan-10> can help here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#681 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ7HSBN3WNZRXMO3RWG7AADSNUICVANCNFSM4SZZCS4Q>
.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#548
@chirag-jn Kindly review the changes.
Thank you.