Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ValueError in phone validator #552

Merged
merged 3 commits into from
Nov 16, 2024

Remove custom Phone exception

7739461
Select commit
Loading
Failed to load commit list.
Merged

Raise ValueError in phone validator #552

Remove custom Phone exception
7739461
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 16, 2024 in 1s

81.52% (-0.02%) compared to 09ed49e

View this Pull Request on Codecov

81.52% (-0.02%) compared to 09ed49e

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.52%. Comparing base (09ed49e) to head (7739461).

Files with missing lines Patch % Lines
app/utils/validators.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   81.53%   81.52%   -0.02%     
==========================================
  Files         128      128              
  Lines        9943     9942       -1     
==========================================
- Hits         8107     8105       -2     
- Misses       1836     1837       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.