Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ValueError in phone validator #552

Merged
merged 3 commits into from
Nov 16, 2024
Merged

Raise ValueError in phone validator #552

merged 3 commits into from
Nov 16, 2024

Conversation

armanddidierjean
Copy link
Member

to let FastAPI return Pydantic ValidationError instead of crashing

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.52%. Comparing base (09ed49e) to head (7739461).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/utils/validators.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   81.53%   81.52%   -0.02%     
==========================================
  Files         128      128              
  Lines        9943     9942       -1     
==========================================
- Hits         8107     8105       -2     
- Misses       1836     1837       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximeroucher maximeroucher merged commit 4ebe404 into main Nov 16, 2024
7 checks passed
@maximeroucher maximeroucher deleted the phone-validator branch November 16, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core fix bug This PR fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants