Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-157888 - Hero marquee w/ no-min-height and no l/r padding when using a full-width variant in masonry(repost) #2923

Merged
merged 10 commits into from
Oct 1, 2024
Merged

MWPW-157888 - Hero marquee w/ no-min-height and no l/r padding when using a full-width variant in masonry(repost) #2923

merged 10 commits into from
Oct 1, 2024

Commits on Sep 19, 2024

  1. conditional check for linkPic

    @ryanmparrish
    ryanmparrish committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    66d094b View commit details
    Browse the repository at this point in the history

  2. Add no-min-height and check if elementIsEmpty before decorate row

    @ryanmparrish
    ryanmparrish committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    790d98f View commit details
    Browse the repository at this point in the history

  3. revert decorate change. in diff pr

    @ryanmparrish
    ryanmparrish committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    24c6a56 View commit details
    Browse the repository at this point in the history

  4. childNodes instead of specific elements

    @ryanmparrish
    ryanmparrish committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5d09c50 View commit details
    Browse the repository at this point in the history

  5. remove console

    @ryanmparrish
    ryanmparrish committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    94b0c65 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. added test mocks for empty or element based bg content. Added style f… 

    …or -up .full-width
    @ryanmparrish
    ryanmparrish committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6612c4e View commit details
    Browse the repository at this point in the history

  2. added better test coverage and simplified the isElementEmpty

    @ryanmparrish
    ryanmparrish committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    58b1f71 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. simplified logic to check if head element is empty

    @ryanmparrish
    ryanmparrish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    534d292 View commit details
    Browse the repository at this point in the history

  2. removed unused func

    @ryanmparrish
    ryanmparrish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ac2b9f3 View commit details
    Browse the repository at this point in the history

  3. fixed text mock markup

    @ryanmparrish
    ryanmparrish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3c6e71e View commit details
    Browse the repository at this point in the history