MWPW-157888 - Hero marquee w/ no-min-height and no l/r padding when using a full-width variant in masonry(repost) #2923
+28
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: This a repost from reverted PR due to some issues seen w/ bg images not showing. Testing pages didn't have these examples initially so i've added em. Sorry for the bump. :)
As and author in a milo project using a [hero-marquee]
I want to use this block with out a minimal height so the block has a natural height based on content.
I want to use this block in a masonry grid w/ the variant
full-width
and not have the extra left/right padding seen in this scenario.Example screenshot - Notice the block height is huge, the l/r padding is causing the block to go outside its bounds.
Fixed
Add a no-min-height variant to the hero-marquee.
Address padding issue on hero-block. Erroneously comes from the has-bg class being added.
Resolves: MWPW-157888
Test URLs:
Before: https://main--milo--adobecom.hlx.page/drafts/steenmeyer/hero-editorial-layout-pattern-examples/hero-editorial-no-min-height-masonry1?martech=off
After: https://rparrish-hero-bg-fix-2--milo--adobecom.hlx.page/drafts/steenmeyer/hero-editorial-layout-pattern-examples/hero-editorial-no-min-height-masonry1?martech=off
Hero Marquee (regression)
These should all look the same
hero before: https://main--milo--adobecom.hlx.page/docs/library/blocks/hero-marquee?martech=off
hero after: https://rparrish-hero-bg-fix-2--milo--adobecom.hlx.page/docs/library/blocks/hero-marquee?martech=off
hero kitchen before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/hero-marquee?martech=off
hero kitchen after: https://rparrish-hero-bg-fix-2--milo--adobecom.hlx.page/docs/library/kitchen-sink/hero-marquee?martech=off