Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-158777 returning proper response in case of error #2916

Merged
merged 2 commits into from
Sep 19, 2024
Merged

MWPW-158777 returning proper response in case of error #2916

merged 2 commits into from
Sep 19, 2024

Conversation

npeltier
Copy link
Contributor

@npeltier npeltier requested a review from a team as a code owner September 19, 2024 15:47
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@npeltier npeltier requested review from vgoodric and removed request for a team September 19, 2024 15:48
@afmicka afmicka added the run-nala Run Nala Test Automation against PR label Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (647f799) to head (678a398).
Report is 2 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #2916      +/-   ##
==========================================
- Coverage   98.21%   96.24%   -1.98%     
==========================================
  Files          64      236     +172     
  Lines        7848    54254   +46406     
==========================================
+ Hits         7708    52217   +44509     
- Misses        140     2037    +1897

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afmicka afmicka added the verified PR has been E2E tested by a reviewer label Sep 19, 2024
@skumar09 skumar09 removed the run-nala Run Nala Test Automation against PR label Sep 19, 2024
yesil
yesil approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@yesil yesil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a test

@npeltier npeltier merged commit c3c9bcc into adobecom:stage Sep 19, 2024
17 of 18 checks passed
@npeltier npeltier mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgoodric vgoodric vgoodric approved these changes

@mokimo mokimo mokimo approved these changes

@yesil yesil yesil approved these changes

Assignees
No one assigned
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@npeltier @yesil @mokimo @vgoodric @afmicka @skumar09