Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2910

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Release] Stage to Main #2910

wants to merge 8 commits into from

Conversation

Deva309 and others added 2 commits September 19, 2024 00:48
…on (#2892)

Added functionality to disable Active Element Detection
* init plans cards doc

* switch to QA bucket

* add plans html

* add test payload

* upd path

* card

* test hlxignore

* test

* remove test files

* remove edge payload

* add marquee

* add spacing
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Sep 19, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (54c3cc0) to head (1791eb8).
Report is 51 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2910   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         236      236           
  Lines       54233    54278   +45     
=======================================
+ Hits        52196    52241   +45     
  Misses       2037     2037           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* MWPW-154059 - Milo templates library

* Allows template-metadata block to output metadata block in template
* Fixes inital listing order
* Adds search ability to templates

Resolves: MWPW-154059

* Updating unit tests

* Addressing eslint issue

* Address PR feedback

---------

Co-authored-by: Ryan Clayton <[email protected]>
…ation (#2913)

* support cross-domain localization on stage links conversion

* Update libs/utils/utils.js

Co-authored-by: Rares Munteanu <[email protected]>

* hotfix

---------

Co-authored-by: Rares Munteanu <[email protected]>
Update self hosted dependency

Co-authored-by: GitHub Action <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

skumar09 and others added 2 commits September 19, 2024 16:12
* update readme with nala commands

* update few command sentences

* horizontal line

* update horizontal line

* update heading

* update nala wiki link

---------

Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
* MWPW-158674 [MEP] Support nested placholders in MEP placeholders

* unit test

* move match functionality to reusable function

* add default value for info in getManifestConfig declaration

* MWPW-158142 [MEP] check for MEP placeholders as fragmentless content is inserted (#2919)

* Initial checkin. Working state.

* Code refactor.

* Unit test initial checkin.

* Refactor into reusable function.

* Removed old code.

* Linting.

* update unit test to call create content

---------

Co-authored-by: vgoodric <[email protected]>

---------

Co-authored-by: Dave Linhart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants