MWPW-158071: Optimize LCP loading times #2914
Open
+48
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokimo
requested review from
narcis-radu,
overmyheadandbody and
robert-bogos
mokimo
commented
Sep 19, 2024
| @@ -731,6 +731,8 @@ function decorateDefaults(el) { | |||
| } | |||
|
|
|||
| function decorateHeader() { | |||
| const breadcrumbs = document.querySelector('.breadcrumbs'); | |||
There was a problem hiding this comment.
I noticed that if a breadcrumbs is authored as first block, we immediately load it. The global-navigation should take care of this and on L752 we move the breadcrumbs into the header if (breadcrumbs) header.append(breadcrumbs);
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2914 +/- ##
========================================
Coverage ? 96.24%
========================================
Files ? 236
Lines ? 54265
Branches ? 0
========================================
Hits ? 52228
Misses ? 2037
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
nala tests also failing on stage: #2910 |
chrischrischris
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's relatively hard to track performance beforehand, however we observed a +500MS (13%) gain on CC pages speeding up loading placeholders. We've also seen good success with preloading
Decorate.js
This PR initially introduced the idea of preloading
decorate.jsfor a performance gain, but introduced too much flexibility. The idea of preloadingdecorate.jsfor specifically the two common (hero-)marquees blocks is valuable and worth the added 3 lines of code, as neither is likely to change anytime soon.Impressions
This should provide good benefits on a wide arrange of blocks, consumers and pages by optimizing the load order and chains, however we will want to observe the CRUM/RUM/CRUX data after merging the changes in this PR.
Given the success we seen with preloading & parallelizing work in general, this harmonizes the timeline and ensures the browser loads everything as fast as it can, without any impact on TBT/CLS.
Before
After
Resolves: MWPW-158071
Test URLs:
Bacom
CC