Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-158674 [MEP] Support nested placholders in MEP placeholders #2908

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

vgoodric
Copy link
Contributor

@vgoodric vgoodric commented Sep 18, 2024

  • Support using a MEP placeholder in a MEP placeholder.

Resolves: MWPW-158674

Sample page tests:

  1. the nested placeholder being before, after or in a different manifest than the one that uses it
  2. a nested placeholder is defined twice and the last definition is used

QA instructions:
H1 should read: Buy now and save 50% off CC All Apps.
Description should start with: For just US$49.99,

Test URLs:

Also includes #2919 for conflict resolution

@vgoodric vgoodric requested a review from a team as a code owner September 18, 2024 23:39
Copy link
Contributor

aem-code-sync bot commented Sep 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 18, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (c3c9bcc) to head (130b5e0).
Report is 1 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2908   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         236      236           
  Lines       54254    54278   +24     
=======================================
+ Hits        52217    52241   +24     
  Misses       2037     2037           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to mepnestedplaceholders September 18, 2024 23:48 Inactive
@vgoodric vgoodric requested a review from a team September 18, 2024 23:49
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@aem-code-sync aem-code-sync bot temporarily deployed to mepnestedplaceholders September 19, 2024 15:42 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mepnestedplaceholders September 19, 2024 17:30 Inactive
@vgoodric vgoodric added verified PR has been E2E tested by a reviewer Ready for Stage labels Sep 19, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to mepnestedplaceholders September 19, 2024 17:38 Inactive
…is inserted (#2919)

* Initial checkin. Working state.

* Code refactor.

* Unit test initial checkin.

* Refactor into reusable function.

* Removed old code.

* Linting.

* update unit test to call create content

---------

Co-authored-by: vgoodric <[email protected]>
@milo-pr-merge milo-pr-merge bot merged commit 1791eb8 into stage Sep 19, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot deleted the mepnestedplaceholders branch September 19, 2024 20:10
@milo-pr-merge milo-pr-merge bot mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants