[MWPW-157924] - Added functionality to disable Active Element Detection #2892
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deva309
requested review from
salonijain3,
bandana147,
sharmrj,
nishantka and
sonawanesnehal3
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2892 +/- ##
==========================================
- Coverage 96.23% 96.22% -0.01%
==========================================
Files 237 237
Lines 54242 54259 +17
==========================================
+ Hits 52198 52213 +15
- Misses 2044 2046 +2 ☔ View full report in Codecov by Sentry. |
bandana147
approved these changes
Sep 18, 2024
nishantka
approved these changes
Sep 18, 2024
sonawanesnehal3
approved these changes
Sep 18, 2024
sharmrj
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents any NavItem from being marked as active by appending the hash
#_noActiveItemto thegnav-source. The hash can be added either in themetadata.xlsxfile or at the page level for thegnav-sourcemetadata. If the hash is present, the Active Element Detection functionality is disabled.For example:
Before (creativity & design is active NavItem):
After (No NavItem is active):
Resolves: MWPW-157924
Test URLs:
QA:
https://main--cc--adobecom.hlx.page/drafts/devashish/vh?milolibs=mwpw-157924--milo--deva309