Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-157973] Run Nala checks on all PRs by default #2877

Merged
merged 46 commits into from
Sep 16, 2024

Conversation

robert-bogos
Copy link
Contributor

Description

This PR updates the Git workflow to run Nala checks on all PRs by default.

Related Issue

Resolves: MWPW-157973

Testing instructions

See that the Nala Tests are running on this PR without having the run-nala label added.

PSI check URL

https://mwpw-157973-nala-by-default--milo--robert-bogos.hlx.page/drafts/rbogos/page-default?martech=off

@robert-bogos robert-bogos requested a review from a team September 13, 2024 07:09
@robert-bogos robert-bogos self-assigned this Sep 13, 2024
Copy link
Contributor

aem-code-sync bot commented Sep 13, 2024

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (3fd877c) to head (1c83043).
Report is 16 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2877      +/-   ##
==========================================
+ Coverage   96.09%   96.26%   +0.16%     
==========================================
  Files         215      238      +23     
  Lines       53954    54310     +356     
==========================================
+ Hits        51849    52279     +430     
+ Misses       2105     2031      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviuLCF SilviuLCF self-requested a review September 16, 2024 08:15
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero impact PR , no QA needed

Ready for STAGE

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 16, 2024

Error merging 2877: [MWPW-157973] Run Nala checks on all PRs by default Resource not accessible by integration

@mokimo mokimo merged commit cb05c67 into adobecom:stage Sep 16, 2024
16 checks passed
@mokimo mokimo mentioned this pull request Sep 16, 2024
@overmyheadandbody
Copy link
Contributor

@robert-bogos & @skumar09 - should we also delete the label, since it would not achieve anything at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants