Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2879

Merged
merged 6 commits into from
Sep 17, 2024
Merged

[Release] Stage to Main #2879

merged 6 commits into from
Sep 17, 2024

Conversation

sonawanesnehal3 and others added 3 commits September 16, 2024 08:52
* Adding container for for search in standalone gnav

* Updating class name

* Adding unit test

* Removing space to fix eslint issue

* Updating unit test

* Updating unit test

* Accommodating review comments

* Fixing Eslint

* Accommodating review comments

* Updating client search

* Updating client search

---------

Co-authored-by: Snehal Sonawane <[email protected]>
Co-authored-by: Snehal Sonawane <[email protected]>
* eagerloading icons

* eagerloading icons

* eagerloading icons

* eagerloading icons

* eagerloading icons

* eagerloading icons

* eagerloading icons

* eagerloading icons

* eagerloading icons

---------

Co-authored-by: Suhani <[email protected]>
Co-authored-by: Suhani <[email protected]>
@milo-pr-merge
Copy link
Contributor Author

Milo PR Merge bot commented Sep 16, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

Copy link
Contributor

AEM Code Sync bot commented Sep 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

AEM Code Sync bot commented Sep 16, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

Codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (6fa9558) to head (840e037).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
- Coverage   96.25%   96.23%   -0.03%     
==========================================
  Files         238      237       -1     
  Lines       54310    54242      -68     
==========================================
- Hits        52276    52198      -78     
- Misses       2034     2044      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* add nala tests to milo repo

* update the nalarun for single run

* fix georouting test and add eslint overrides for nala files

* add eslint overrides for nala files

* fix operator assignment eslint error

* update eslint lines

* remove eslint disable lines

* move prrun to nala folder

* update the path correctly

* add nala folder to .hlxignore file

* update tag for ost

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
removed run nala label check

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
@aem-code-sync AEM Code Sync bot temporarily deployed to stage September 16, 2024 08:55 Inactive
@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label Sep 16, 2024
Revert "MWPW-154980 - Milo advanced page publishing (#2846)"

This reverts commit 8fd5925.
@JackySun9 JackySun9 added MIQ SOT👌 and removed run-nala Run Nala Test Automation against PR run-nala-on-caas labels Sep 16, 2024
@tedAir tedAir self-requested a review September 16, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.