Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quiz Entry Accessibility Round 2 #2875

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Quiz Entry Accessibility Round 2 #2875

merged 1 commit into from
Sep 18, 2024

Conversation

colloyd
Copy link
Contributor

@colloyd colloyd commented Sep 12, 2024

  • Heading tags based on seo recommendations
  • Adjust disabled button color for bettter contrast
  • Focus reset for quiz options after using carousel nav with a keyboard

Resolves: MWPW-158352

Test URLs:

@colloyd
Quiz Entry Accessibility Round 2
0aabd61 
* Heading tags based on seo recommendations
* Adjust disabled button color for bettter contrast
* Focus reset for quiz options after using carousel nav with a keyboard

Resolves: [MWPW-158352](https://jira.corp.adobe.com/browse/MWPW-158352)
@colloyd colloyd added uar needs-verification PR requires E2E testing by a reviewer labels Sep 12, 2024
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 12, 2024

Page Scores Audits Google
M /drafts/colloyd/quiz-entry/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/colloyd/quiz-entry/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@colloyd colloyd removed their assignment Sep 12, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (6fa9558) to head (0aabd61).
Report is 14 commits behind head on stage.

Additional details and impacted files 
@@           Coverage Diff           @@
##            stage    #2875   +/-   ##
=======================================
  Coverage   96.25%   96.26%           
=======================================
  Files         238      238           
  Lines       54310    54310           
=======================================
+ Hits        52276    52279    +3     
+ Misses       2034     2031    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colloyd colloyd requested a review from a team September 12, 2024 20:23
@JackySun9 JackySun9 added verified PR has been E2E tested by a reviewer run-nala Run Nala Test Automation against PR and removed needs-verification PR requires E2E testing by a reviewer labels Sep 13, 2024
@JackySun9 JackySun9 removed the run-nala Run Nala Test Automation against PR label Sep 13, 2024
JasonHowellSlavin
JasonHowellSlavin reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@JasonHowellSlavin JasonHowellSlavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, are their any unit tests that could be updated?

@colloyd
Copy link
Contributor Author

colloyd commented Sep 13, 2024

@JasonHowellSlavin No, most of this is CSS and the bit of JS refocus that happens doesn't affect code coverage and only applies in keyboard nav situations to make using the carousel nav a bit smoother.

@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 16, 2024

Skipped merging 2875: Quiz Entry Accessibility Round 2 due to failing checks

@colloyd
Copy link
Contributor Author

colloyd commented Sep 17, 2024

Skipped merging 2875: Quiz Entry Accessibility Round 2 due to failing checks

Any ideas on this @JackySun9?

@JackySun9 JackySun9 added run-nala Run Nala Test Automation against PR uar and removed run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer uar Ready for Stage labels Sep 17, 2024
@JackySun9 JackySun9 added verified PR has been E2E tested by a reviewer Ready for Stage run-nala Run Nala Test Automation against PR and removed verified PR has been E2E tested by a reviewer run-nala Run Nala Test Automation against PR uar Ready for Stage labels Sep 17, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 17, 2024

Skipped merging 2875: Quiz Entry Accessibility Round 2 due to failing checks

@mokimo mokimo merged commit b10f86c into adobecom:stage Sep 18, 2024
70 of 76 checks passed
@mokimo mokimo mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackySun9 JackySun9 JackySun9 approved these changes

@JasonHowellSlavin JasonHowellSlavin JasonHowellSlavin approved these changes

@fullcolorcoder fullcolorcoder Awaiting requested review from fullcolorcoder fullcolorcoder is a code owner

Assignees

@JackySun9 JackySun9

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colloyd @JasonHowellSlavin @JackySun9 @mokimo