Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2898

Merged
merged 7 commits into from
Sep 18, 2024
Merged

[Release] Stage to Main #2898

merged 7 commits into from
Sep 18, 2024

Conversation

ryanmparrish and others added 2 commits September 18, 2024 09:16
…ant. (#2853)

* updated authoring experience for 'open' card so they support 3 rows and expects no background

* pass false as defat func bool && early return

* fixed test 404 and example for open 3 rows
… modal background image (#2891)

* Update georoutingv2.css

* Update georoutingv2.js

* Delete libs/features/georoutingv2/getMobileBg.js

* Update georoutingv2.css

* Update georoutingv2.test.js

* Removing unused variable

* Delete libs/features/georoutingv2/img/GeoModal_BG_Map_Desktop.png

* Delete libs/features/georoutingv2/img/GeoModal_BG_Map_Mobile.png

* Delete libs/features/georoutingv2/img/GeoModal_BG_Map_Tablet.png
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Sep 18, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner September 18, 2024 09:16
Copy link
Contributor

aem-code-sync bot commented Sep 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 18, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

* Heading tags based on seo recommendations
* Adjust disabled button color for bettter contrast
* Focus reset for quiz options after using carousel nav with a keyboard

Resolves: [MWPW-158352](https://jira.corp.adobe.com/browse/MWPW-158352)
Revert "MWPW-156749: Fix video CLS  (#2849)"

This reverts commit d4134c8.
@mokimo mokimo changed the base branch from main to plugin-demo September 18, 2024 10:41
@mokimo mokimo changed the base branch from plugin-demo to main September 18, 2024 10:41
* Pulling in link transformer settings in config

* Testing unit tests

* Second attempt

* Third attempt

* Nth attempt

* Fixing linting

* Next attempt

* Next attempt

* Next attempt

* next attempt

* Next attempt

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (9323f28) to head (54c3cc0).
Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2898   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         237      236    -1     
  Lines       54219    54233   +14     
=======================================
+ Hits        52182    52196   +14     
  Misses       2037     2037           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* update run-nala yaml to support running on consuming apps

* update the condition

* update the if condition

* update delimeter correctly

---------

Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
@aem-code-sync aem-code-sync bot temporarily deployed to stage September 18, 2024 16:26 Inactive
@tedAir tedAir self-requested a review September 18, 2024 19:23
…ing when using a `full-width` variant" (#2905)

Revert "MWPW-157888 - Hero marquee w/ `no-min-height` and no l/r padding when…"
This reverts commit eb788ce.
@Blainegunn Blainegunn merged commit 132d69f into main Sep 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.