Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2874

Merged
merged 4 commits into from
Sep 16, 2024
Merged

[Release] Stage to Main #2874

merged 4 commits into from
Sep 16, 2024

Commits on Sep 12, 2024

  1. fix(MWPW-155964):Lana log error type changed to info. (#2818) 

    * lana log error type changed

* modified lana logs

* added a few unit tests for lana logs

* Updated tag in  utils.js

* linting error fixed

* linting error fix 2

* unit test fix

* added unit test for vimeo
    @sharath-kannan
    sharath-kannan authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a7c31b7 View commit details
    Browse the repository at this point in the history

  2. MWPW-154980 - Milo advanced page publishing (#2846) 

    * sidekick publish button state

* bulk publish publish config errors

* dial in functionality add custom messages and denylist

* publish permission in bulk pub testing

* test permissions and utils coverage

* remove extra variable assignment

* add no signin message

* put back timout for init sidekick pub button decoration

* fix edge case where sk event isnt fired on refresh

* fix unit tests

* put back var assignment

* dial in user can publish funtion

* move publish utility to tools dir

* Update tools/utils/utils.js

Co-authored-by: Ryan Parrish <[email protected]>

---------

Co-authored-by: Ryan Parrish <[email protected]>
    @Sartxi @ryanmparrish
    Sartxi and ryanmparrish authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8fd5925 View commit details
    Browse the repository at this point in the history

  3. fix(Mwpw-157971):sticky feature works in landscape mode. (#2856) 

    * sticky-header variants added

* removed sticky header from all mobile devices

* linting error

* Added new sticky variant

* updated the selector for table buttons

* sticky feature adapts to portrait and landscape

* removed linting error
    @sharath-kannan
    sharath-kannan authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4357346 View commit details
    Browse the repository at this point in the history

  4. MWPW-156612 fragment merch-card variant layouts (#2810) 

    * MWPW-156612 fragment merch-card variant layouts

- move from merch-card.js code each layout code related to a given variant under variants/<variant> class
- move from global.css.js css related to a given variant under variants/<variant>.css.js
- move from merch-card.css.js wc css related to a given variant under variants/<variant>.variantStyle
- uses variants/variants as an index to get related class from related variant, and wc style too,
- uses variants/VariantLayout, superclass of all variants, to insert css if card is used, and hold common code

* MWPW-156612 changing title selector

to something independent of the layout (not initialized when used at first in collections)

* MWPW-156612 forking style insertion

* MWPW-156612 styles fixes

* MWPW-156612 review comments

* MWPW-156612 fixing unit tests

* MWPW-156612 address review comments

* MWPW-156612 catalog & image test cov

* MWPW-156612 100% coverage for variants

* MWPW-156612 fixing (again) ut

* MWPW-156612 fix one inline heading style

* MWPW-156612 bg img height
    @npeltier
    npeltier authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6fa9558 View commit details
    Browse the repository at this point in the history