Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2874

Merged
merged 4 commits into from
Sep 16, 2024
Merged

[Release] Stage to Main #2874

merged 4 commits into from
Sep 16, 2024

Conversation

milo-pr-merge[bot]
Copy link
Contributor

@milo-pr-merge milo-pr-merge bot commented Sep 12, 2024 •
edited by rgclayton
Loading

sharath-kannan and others added 3 commits September 12, 2024 17:00
@sharath-kannan
fix(MWPW-155964):Lana log error type changed to info. (#2818)
a7c31b7 
* lana log error type changed

* modified lana logs

* added a few unit tests for lana logs

* Updated tag in  utils.js

* linting error fixed

* linting error fix 2

* unit test fix

* added unit test for vimeo
@Sartxi @ryanmparrish
MWPW-154980 - Milo advanced page publishing (#2846)
8fd5925 
* sidekick publish button state

* bulk publish publish config errors

* dial in functionality add custom messages and denylist

* publish permission in bulk pub testing

* test permissions and utils coverage

* remove extra variable assignment

* add no signin message

* put back timout for init sidekick pub button decoration

* fix edge case where sk event isnt fired on refresh

* fix unit tests

* put back var assignment

* dial in user can publish funtion

* move publish utility to tools dir

* Update tools/utils/utils.js

Co-authored-by: Ryan Parrish <[email protected]>

---------

Co-authored-by: Ryan Parrish <[email protected]>
@sharath-kannan
fix(Mwpw-157971):sticky feature works in landscape mode. (#2856)
4357346 
* sticky-header variants added

* removed sticky header from all mobile devices

* linting error

* Added new sticky variant

* updated the selector for table buttons

* sticky feature adapts to portrait and landscape

* removed linting error
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Sep 12, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 12, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 12, 2024 •
edited
Loading

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (3679fd0) to head (6fa9558).
Report is 51 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2874      +/-   ##
==========================================
+ Coverage   96.18%   96.25%   +0.07%     
==========================================
  Files         215      238      +23     
  Lines       53994    54310     +316     
==========================================
+ Hits        51933    52276     +343     
+ Misses       2061     2034      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@npeltier
MWPW-156612 fragment merch-card variant layouts (#2810)
6fa9558 
* MWPW-156612 fragment merch-card variant layouts

- move from merch-card.js code each layout code related to a given variant under variants/<variant> class
- move from global.css.js css related to a given variant under variants/<variant>.css.js
- move from merch-card.css.js wc css related to a given variant under variants/<variant>.variantStyle
- uses variants/variants as an index to get related class from related variant, and wc style too,
- uses variants/VariantLayout, superclass of all variants, to insert css if card is used, and hold common code

* MWPW-156612 changing title selector

to something independent of the layout (not initialized when used at first in collections)

* MWPW-156612 forking style insertion

* MWPW-156612 styles fixes

* MWPW-156612 review comments

* MWPW-156612 fixing unit tests

* MWPW-156612 address review comments

* MWPW-156612 catalog & image test cov

* MWPW-156612 100% coverage for variants

* MWPW-156612 fixing (again) ut

* MWPW-156612 fix one inline heading style

* MWPW-156612 bg img height
github-actions[bot]
github-actions bot reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/image.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/inline-heading.css.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/inline-heading.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/mini-compare-chart.css.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/mini-compare-chart.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/plans.css.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/plans.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/product.css.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/product.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/segment.css.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/segment.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/special-offer.css.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/special-offer.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/twp.css.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/twp.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/variant-layout.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/src/variants/variants.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/test/merch-card.catalog.test.html.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/test/merch-card.mini-compare.mobile.test.html.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/test/merch-card.mini-compare.test.html.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/test/merch-card.special-offer.test.html.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/test/merch-card.test.html.js

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/6fa95584902286108cfea82572288559b3517bb0/libs/features/mas/web-components/test/utils.js

github-actions[bot]
github-actions bot reviewed Sep 12, 2024
View reviewed changes
libs/deps/mas/merch-card.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 12, 2024
View reviewed changes
libs/deps/mas/plans-modal.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 12, 2024
View reviewed changes
libs/features/mas/web-components/src/global.css.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 12, 2024
View reviewed changes
libs/features/mas/web-components/src/merch-card.css.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 12, 2024
View reviewed changes
libs/features/mas/web-components/src/merch-card.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 12, 2024
View reviewed changes
libs/features/mas/web-components/src/variants/catalog.css.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 12, 2024
View reviewed changes
libs/features/mas/web-components/src/variants/catalog.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@milo-pr-merge milo-pr-merge bot merged commit b60741a into main Sep 16, 2024
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@Roycethan Roycethan Roycethan approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@Dli3 Dli3 Dli3 approved these changes

@Sartxi Sartxi Sartxi approved these changes

@hparra hparra hparra approved these changes

@meganthecoder meganthecoder Awaiting requested review from meganthecoder meganthecoder is a code owner

@JasonHowellSlavin JasonHowellSlavin Awaiting requested review from JasonHowellSlavin JasonHowellSlavin is a code owner

@Brandon32 Brandon32 Awaiting requested review from Brandon32 Brandon32 is a code owner

@colloyd colloyd Awaiting requested review from colloyd colloyd is a code owner

@sabyamon sabyamon Awaiting requested review from sabyamon sabyamon is a code owner

@fullcolorcoder fullcolorcoder Awaiting requested review from fullcolorcoder fullcolorcoder is a code owner

@seanchoi-dev seanchoi-dev Awaiting requested review from seanchoi-dev seanchoi-dev is a code owner

@rgclayton rgclayton Awaiting requested review from rgclayton rgclayton is a code owner

Assignees
No one assigned
Labels
BAcom SOT 👌 CC SOT 👌 Homepage SOT 👌 MIQ SOT👌 run-nala Run Nala Test Automation against PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@hparra @Sartxi @Dli3 @JackySun9 @Roycethan @sigadamvenkata @mokimo @sharath-kannan @npeltier