MWPW-154059 - Milo templates library #2855
Conversation
* Allows template-metadata block to output metadata block in template * Fixes inital listing order * Adds search ability to templates Resolves: MWPW-154059
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2855 +/- ##
==========================================
+ Coverage 95.91% 96.24% +0.33%
==========================================
Files 173 236 +63
Lines 45831 54233 +8402
==========================================
+ Hits 43958 52196 +8238
- Misses 1873 2037 +164 ☔ View full report in Codecov by Sentry. |
|
Will look into unit tests. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
aem-code-sync
bot
temporarily deployed
to
template-library-updates
aem-code-sync
bot
temporarily deployed
to
template-library-updates
| @@ -32,27 +32,47 @@ async function loadPersonalization(content, list) { | |||
| personalization(content, list); | |||
| } | |||
|
|
|||
| function addSearch(content, list) { | |||
| function addSearch(content, list, type) { | |||
There was a problem hiding this comment.
Same as above. I think it would be good to pass an object.
| function addSearch(content, list, type) { | |
| function addSearch({ content, list, type }) { |
|
Reminder to set the |
There was a problem hiding this comment.
Verified , ready for STAGE
Testing details https://jira.corp.adobe.com/browse/MWPW-154059
template-metadatablock to be pasted asmetadatablock in templateResolves: MWPW-154059
Test URLs:
BACOM Test URLs:
Testing notes:
With the updated features, the template named "demo" has search tags added (Rc-special demo test) via of a
library-metadatablock. This block allows authors to add custom search tags to the template. Searching with any of those tags will pull up the "Demo" template. However, when the template is copied from the library and pasted to a Word doclibrary-metadatablock should not be part of the copied blocks.Testing this using the
mainbranch will copy thelibrary-metadatablock to the Word doc.To include a
metadatablock in the template, to be pasted into the Word doc, the template must include atemplate-metadatablock with all the needed metadata fields. Once, pasted in the page that block converted tometadataand displays as a metadata block.If a
library-metadatablock with the key value pair (searchTagsand search words) is added to a template, that template will be searchable by the name of the template along with the search words added tolibrary-metadata.Block searching should continue to work as it's always worked.