Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2742

Merged
merged 8 commits into from
Aug 19, 2024
Merged

[Release] Stage to Main #2742

merged 8 commits into from
Aug 19, 2024

Commits on Aug 14, 2024

  1. [MWPW-154970] allow authoring hash value delay=0 for promo modals (#2706 

    )

allow authoring delay=0 for modals
    @Ruchika4
    Ruchika4 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    01da50f View commit details
    Browse the repository at this point in the history

  2. MWPW-153810 media image is seen loaded twice in product page urls in … 

    …desktop (#2715)

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* Update body.html

* Update utils.test.js
    @suhjainadobe
    suhjainadobe committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3c9774c View commit details
    Browse the repository at this point in the history

  3. MWPW-146031 [MEP] Existing Personalization Tag UPDATE: Photoshop-any (#… 

    …2735)

update id's
    @vgoodric
    vgoodric committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8e03d6e View commit details
    Browse the repository at this point in the history

  4. MWPW-156624 [MILO][MEP] Add locale prefix as an option for placeholde… 

    …r feature (#2736)

* mepgeofolder

* Update libs/features/personalization/preview.js

Co-authored-by: Mark Perry <[email protected]>

* MWPW-156545 [MILO][MEP] Info in MEP button panel is incorrect (#2729)

* stash

* add override existance to if check

---------

Co-authored-by: Mark Perry <[email protected]>
    @vgoodric @markpadbe
    vgoodric and markpadbe committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d0f2a37 View commit details
    Browse the repository at this point in the history

  5. [AUTOMATED-PR] Update imslib.min.js dependency (#2740) 

    Update self hosted dependency

Co-authored-by: GitHub Action <[email protected]>
    @github-actions @actions-user
    github-actions[bot] and actions-user committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    fea8180 View commit details
    Browse the repository at this point in the history

  6. MWPW-155412: Fix video CLS netting +10 lighthouse points (#2724) 

    * fix cls by adding the videoEl without a source

* adapt the video hover and in view port play

* Remove no-lazy and return earlier

* Fix linting issue

* Consolidate duplicated logic

* Move functions into the init function

* Move root margin and use optional chaining

* Only query for the videoEl once
    @mokimo
    mokimo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e9fa699 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Revert "MWPW-155412: Fix video CLS netting +10 lighthouse points" (#2748 

    )

Revert "MWPW-155412: Fix video CLS netting +10 lighthouse points (#2724)"

This reverts commit e9fa699.
    @mokimo
    mokimo committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    96de2ac View commit details
    Browse the repository at this point in the history

  2. [MWPW-156746] Use correct paths for lint:css script (#2749)

    @overmyheadandbody
    overmyheadandbody committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f92f07c View commit details
    Browse the repository at this point in the history