Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2742

Merged
merged 8 commits into from
Aug 19, 2024
Merged

[Release] Stage to Main #2742

merged 8 commits into from
Aug 19, 2024

Conversation

milo-pr-merge[bot]
Copy link
Contributor

@milo-pr-merge milo-pr-merge bot commented Aug 14, 2024 •
edited by overmyheadandbody
Loading

Reverted

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

Ruchika4 and others added 4 commits August 14, 2024 08:19
@Ruchika4
[MWPW-154970] allow authoring hash value delay=0 for promo modals (#2706
01da50f 
)

allow authoring delay=0 for modals
@suhjainadobe
MWPW-153810 media image is seen loaded twice in product page urls in …
3c9774c 
…desktop (#2715)

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* Update body.html

* Update utils.test.js
@vgoodric
MWPW-146031 [MEP] Existing Personalization Tag UPDATE: Photoshop-any (#…
8e03d6e 
…2735)

update id's
@vgoodric @markpadbe
MWPW-156624 [MILO][MEP] Add locale prefix as an option for placeholde…
d0f2a37 
…r feature (#2736)

* mepgeofolder

* Update libs/features/personalization/preview.js

Co-authored-by: Mark Perry <[email protected]>

* MWPW-156545 [MILO][MEP] Info in MEP button panel is incorrect (#2729)

* stash

* add override existance to if check

---------

Co-authored-by: Mark Perry <[email protected]>
@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner August 14, 2024 08:20
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Aug 14, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Aug 14, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Aug 14, 2024 •
edited
Loading

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (302e9be) to head (f92f07c).
Report is 45 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2742      +/-   ##
==========================================
- Coverage   95.89%   95.88%   -0.02%     
==========================================
  Files         173      173              
  Lines       45746    45771      +25     
==========================================
+ Hits        43870    43886      +16     
- Misses       1876     1885       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions @actions-user
[AUTOMATED-PR] Update imslib.min.js dependency (#2740)
fea8180 
Update self hosted dependency

Co-authored-by: GitHub Action <[email protected]>
@mokimo
MWPW-155412: Fix video CLS netting +10 lighthouse points (#2724)
e9fa699 
* fix cls by adding the videoEl without a source

* adapt the video hover and in view port play

* Remove no-lazy and return earlier

* Fix linting issue

* Consolidate duplicated logic

* Move functions into the init function

* Move root margin and use optional chaining

* Only query for the videoEl once
@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label Aug 14, 2024
Dli3
Dli3 requested changes Aug 15, 2024
View reviewed changes
Copy link

@Dli3 Dli3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're seeing the video controls display and autoplay not working on the marquee in this latest PR on bacom. Reproducible on all browsers.
image
Producible on: https://business.stage.adobe.com/products/real-time-customer-data-platform/rtcdp.html?milolibs=stage

Not reproducible on main: https://business.adobe.com/products/real-time-customer-data-platform/rtcdp.html
cc @mokimo @JasonHowellSlavin @Brandon32

@milo-pr-merge milo-pr-merge bot merged commit 53f37de into main Aug 19, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dli3 Dli3 Dli3 approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@Roycethan Roycethan Roycethan approved these changes

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@tedAir tedAir Awaiting requested review from tedAir

Assignees
No one assigned
Labels
BAcom SOT 👌 CC SOT 👌 Homepage SOT 👌 MIQ SOT👌 run-nala Run Nala Test Automation against PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mokimo @Dli3 @JackySun9 @Roycethan @sigadamvenkata @Ruchika4 @suhjainadobe @vgoodric @overmyheadandbody