Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-158834 #818

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions acrobat/blocks/verb-widget/verb-widget.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
Too many blank lines at the beginning of file. Max of 0 allowed.

import LIMITS from './limits.js';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.

shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging');

Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,12 @@ export default async function init(element) {
const widgetButton = createTag('label', { for: 'file-upload', class: 'verb-cta' }, window.mph['verb-widget-cta']);
const widgetMobileButton = createTag('a', { class: 'verb-mobile-cta', href: mobileLink }, window.mph['verb-widget-cta-mobile']);
const button = createTag('input', { type: 'file', id: 'file-upload', class: 'hide' });
const widgetImage = createTag('img', { class: 'verb-image', src: children[1].querySelector('img')?.src });
const widgetImage = createTag('img', { class: 'verb-image', src: `/acrobat/img/verb-widget/${VERB}.png` });
// Since we're using placeholders we need a solution for the hyperlinks
const legal = createTag('p', { class: 'verb-legal' }, window.mph['verb-widget-legal']);
const legal = createTag('p', { class: 'verb-legal' }, `${window.mph['verb-widget-legal']} `);
const terms = createTag('a', { class: 'verb-legal-url', target: '_blank', href: 'https://www.adobe.com/legal/terms.html' }, window.mph.tou);
const and = createTag('span', { class: 'verb-legal-url' }, ` ${window.mph.and} `);
const privacy = createTag('a', { class: 'verb-legal-url', target: '_blank', href: 'https://www.adobe.com/privacy/policy.html' }, `${window.mph.pp}.`);
const iconSecurity = createTag('div', { class: 'security-icon' });
const footer = createTag('div', { class: 'verb-footer' });

Expand All @@ -102,6 +105,9 @@ export default async function init(element) {
} else {
widgetLeft.append(widgetHeader, widgetHeading, widgetCopy, errorState, widgetButton, button);
}

legal.append(terms, and, privacy);

footer.append(iconSecurity, legal);

element.append(widget, footer);
Expand Down
Binary file added acrobat/img/verb-widget/fillsign.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading