Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-158834 #818

Merged
merged 1 commit into from
Sep 19, 2024
Merged

MWPW-158834 #818

merged 1 commit into from
Sep 19, 2024

Conversation

Blainegunn
Copy link
Collaborator

Resolves : MWPW-158834

@Blainegunn Blainegunn added this to the 0.2439 milestone Sep 19, 2024
Copy link

aem-code-sync bot commented Sep 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@Blainegunn Blainegunn merged commit 01e5662 into stage Sep 19, 2024
6 of 8 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.45%. Comparing base (8bce0c7) to head (9228800).
Report is 2 commits behind head on stage.

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #818      +/-   ##
==========================================
- Coverage   70.51%   70.45%   -0.06%     
==========================================
  Files          47       47              
  Lines        7064     7070       +6     
==========================================
  Hits         4981     4981              
- Misses       2083     2089       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
Too many blank lines at the beginning of file. Max of 0 allowed.

import LIMITS from './limits.js';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.

shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants