Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default configs #3

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix default configs #3

merged 1 commit into from
Jul 24, 2024

Conversation

fuzzypixelz
Copy link
Member

@fuzzypixelz fuzzypixelz commented Jul 24, 2024 •
edited
Loading

Attempting to run the router on d9bc313 results in:

$ ros2 run rmw_zenoh_cpp rmw_zenohd
logging system isn't initialized: call to rcutils_logging_console_output_handler failed.
[ros2run]: Process exited with failure 1

This is because the config format changed in eclipse-zenoh/zenoh@b31a410 (see ros2#237).

@fuzzypixelz fuzzypixelz added the bug Something isn't working label Jul 24, 2024
@fuzzypixelz fuzzypixelz self-assigned this Jul 24, 2024
@YuanYuYuan
Copy link
Collaborator

LGTM.

@YuanYuYuan YuanYuYuan merged commit 5d3cd52 into dev/1.0.0 Jul 24, 2024
4 of 7 checks passed
@YuanYuYuan YuanYuYuan deleted the fix-default-configs branch July 24, 2024 10:10
YuanYuYuan pushed a commit that referenced this pull request Jul 31, 2024
@fuzzypixelz @YuanYuYuan
Fix scouting/*/autoconnect/* per eclipse-zenoh/zenoh@b31a410 (#3)
fdc05d9
YuanYuYuan pushed a commit that referenced this pull request Aug 6, 2024
@fuzzypixelz @YuanYuYuan
Fix scouting/*/autoconnect/* per eclipse-zenoh/zenoh@b31a410 (#3)
28f2fe8
imstevenpmwork pushed a commit that referenced this pull request Aug 8, 2024
@fuzzypixelz @imstevenpmwork
Fix scouting/*/autoconnect/* per eclipse-zenoh/zenoh@b31a410 (#3)
184e9eb
YuanYuYuan pushed a commit that referenced this pull request Aug 9, 2024
@fuzzypixelz @YuanYuYuan
Fix scouting/*/autoconnect/* per eclipse-zenoh/zenoh@b31a410 (#3)
a717270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanYuYuan YuanYuYuan Awaiting requested review from YuanYuYuan

Assignees

@fuzzypixelz fuzzypixelz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzypixelz @YuanYuYuan