-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3 support via future package #466
Open
gokceneraslan
wants to merge
21
commits into
Yelp:master
Choose a base branch
from
gokceneraslan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All old_divs are cleaned up upon futurize since integer division was not needed. All unit tests pass.
Update pyramid configurations in order to make MOE more Python3 compatible. WebError is unmaintained, pyramid_debugtoolbar is preferred instead. waitress is the default server.
This was referenced Sep 4, 2016
sorry to "necro-bump" but is this finally merged/fixed? It seems I'm having issues when attempting to build/use MOE with python3 as the default python version |
I guess this is not maintained any more. Maybe someone should help porting https://github.com/wujian16/Cornell-MOE to Python 3. |
I see, thanks a lot for the pointer!
…On Tue, Nov 7, 2017 at 10:19 AM, Gökçen Eraslan ***@***.***> wrote:
I guess this is not maintained any more. Maybe someone should help porting
https://github.com/wujian16/Cornell-MOE to Python 3.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#466 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AI0169guVSK8XzPgwE4ahZ4K3f0iqlXDks5s0HT-gaJpZM4J0a6j>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
easy_interface
work nicely.Some help is needed for updating conda-recipe (if needed), testing Python3 with docker and updating documentation properly. Also proper testing of the web interface is required.
As a future task, splitting client and server implementations into two python packages would be really convenient, IMHO. Clients should not bother with cmake and rest of the server implementation.