Add Python 3 support via future package #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 4, 2016 03:27
Otherwise, running dragonn without any commands throws an exception in Python3.
|
@gokceneraslan: Agreed - thanks for adding python 3 support, I'll merge soon. We might take out MOE altogether for the next release and replace with simple heuristics that work well for architecture search. |
|
@gokceneraslan: Thanks so much for these fixes! We've incorporated most of them into f7557f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added proper Python 3 support using the future package. Please consider switching to Python 3 by default, before many contributors get involved. Such cool projects shouldn't set out with Python 2 and encourage it. I think except for MOE, there is no reason to stick to Python 2. For MOE, I already made an attempt to port it into Python 3, see Yelp/MOE#466. I hope it'll be integrated at some point.