-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to shadcn CLI 2.0 #61
base: main
Are you sure you want to change the base?
Conversation
Qodana Community for JVM1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: true Contact Qodana teamContact us at [email protected]
|
2ba3888
to
16bef6c
Compare
Qodana Community for JVM1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: true Contact Qodana teamContact us at [email protected]
|
Whats the state on this? Any way I can help so we can make this land? |
Hi! I kinda got overwhelmed by all I have to implement, but as soon as I’ve got time (around the beginning of January) I get back to it. Seeing that people care helps, sorry for the delay Any help is greatly appreciated though, tell me what you wanna start with! |
I'd be happy to start looking into the tailwind config part of it. The question that I have right now is if there is any way to release the config update already without the new features along the lines of blocks an v0. So Projects can at least use the plugin with existing features? |
Definitely! Start a new PR and I can release a patch of 0.8 with that |
Looking through the component json for the button, I think it'll be the best course of action to create the lib folder and the content, which currently from what I can tell only consists of the utils.ts file and add the class-variance-authority package if it doesn't exist yet. Everything else should be mostly compatible |
Looking a bit more into it, we shouldn't have to add the lib/utils.ts file ourselves, as that is written by the init command of the cli, which should have already been ran |
Fixes #60.
Shadcn just released his 2.0 CLI, which adds a bunch of new features, mainly new ways of installing things and more things to install.
As a result, the
components.json
schema has been updated and the plugin is incompatible with it.This PR aims to bridge the introduced gap by achieving feature parity without breaking other shadcn/ui implementations.
TODO list
This list will be updated as I uncover more details about what's changed and what I actually need to implement among all the changes. Shad isn’t known for his extensive technical changelogs and PR descriptions, so that might be a hard task, and I might miss some of them; let me know if that's the case!
hooks
andlib
)login-01
)http://v0.dev/chat/b/xxxxxxx
)theme-*
?) - can break CSS variables