fix(config): Enhance ReactConfig and improve file handling logic #71
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new properties to ReactConfig, including `iconLibrary` and extended aliases with `lib` and `hooks`. These have been added by the 2.0 CLI. Improved filtering of `package.json` files to exclude hidden directories and added logic to remove block comments in Source parsing.
WarningImHack3r
requested changes
Dec 17, 2024
| @@ -111,6 +111,8 @@ abstract class Source<C : Config>(val project: Project, private val serializer: | |||
| .split("\n").joinToString("\n") { line -> | |||
| // Remove // comments | |||
| line.substringBefore("//").trim() | |||
| // Remove /* */ comments | |||
| line.replace(Regex("/\\*.*?\\*/"), "").trim() | |||
There was a problem hiding this comment.
Alright, I'll look into a more robust solution for this tomorrow
| @@ -23,7 +23,8 @@ class ISPPanelPopulator(private val project: Project) { | |||
| CoroutineScope(SupervisorJob() + Dispatchers.Default).async { | |||
| return@async Pair( | |||
| SourceScanner.findShadcnImplementation(project), | |||
| FileManager.getInstance(project).getVirtualFilesByName("package.json").size | |||
| FileManager.getInstance(project).getVirtualFilesByName("package.json") | |||
| .filter { !it.parent.name.startsWith('.') }.size | |||
There was a problem hiding this comment.
You can add this directly inside the getVirtualFilesByName function instead
Was it an issue you encountered?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new properties to ReactConfig, including
iconLibraryand extended aliases withlibandhooks. These have been added by the 2.0 CLI.Improved filtering of
package.jsonfiles to exclude hidden directories and added logic to remove block comments in Source parsing.Implements changes first made in #61