Feat/revamp lean review #108
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduard-dumitru
force-pushed
the
feat/revamp_lean_review
branch
from
a4c8e5c
to
d50e6ab
Compare
| @@ -58,7 +41,7 @@ namespace UiPath.Ipc | |||
| { | |||
| public EndpointSettings(System.Type contractType, System.IServiceProvider serviceProvider) { } | |||
| public EndpointSettings(System.Type contractType, object? serviceInstance = null) { } | |||
| public System.Func<UiPath.Ipc.CallInfo, System.Threading.CancellationToken, System.Threading.Tasks.Task>? BeforeCall { get; set; } | |||
| public System.Func<UiPath.Ipc.CallInfo, System.Threading.CancellationToken, System.Threading.Tasks.Task>? BeforeIncommingCall { get; set; } | |||
| @@ -58,7 +41,7 @@ namespace UiPath.Ipc | |||
| { | |||
| public EndpointSettings(System.Type contractType, System.IServiceProvider serviceProvider) { } | |||
| public EndpointSettings(System.Type contractType, object? serviceInstance = null) { } | |||
| public System.Func<UiPath.Ipc.CallInfo, System.Threading.CancellationToken, System.Threading.Tasks.Task>? BeforeCall { get; set; } | |||
| public System.Func<UiPath.Ipc.CallInfo, System.Threading.CancellationToken, System.Threading.Tasks.Task>? BeforeIncommingCall { get; set; } | |||
| public System.Type ContractType { get; } | |||
| public System.Threading.Tasks.TaskScheduler? Scheduler { get; set; } | |||
| public object? ServiceInstance { get; } | |||
There was a problem hiding this comment.
public interface IClientState - why is it public? along with the CreateState() method in ClientTransport impl
- IServerState, same question
| public System.Func<System.Threading.CancellationToken, System.Threading.Tasks.Task>? BeforeConnect { get; set; } | ||
| public System.Func<UiPath.Ipc.CallInfo, System.Threading.CancellationToken, System.Threading.Tasks.Task>? BeforeOutgoingCall { get; set; } | ||
| public UiPath.Ipc.EndpointCollection? Callbacks { get; set; } | ||
| public string DebugName { get; set; } |
| @@ -133,27 +113,21 @@ namespace UiPath.Ipc | |||
| public void Dispose() { } | |||
| protected override object? Invoke(System.Reflection.MethodInfo? targetMethod, object?[]? args) { } | |||
| } | |||
| public sealed class IpcServer : System.IAsyncDisposable | |||
| public sealed class IpcServer : UiPath.Ipc.Peer, System.IAsyncDisposable | |||
| protected ServerTransport() { } | ||
| public int ConcurrentAccepts { get; set; } | ||
| public byte MaxReceivedMessageSizeInMegabytes { get; set; } | ||
| public System.Security.Cryptography.X509Certificates.X509Certificate? Certificate { get; init; } |
There was a problem hiding this comment.
Decide Certificate best location
eduard-dumitru
force-pushed
the
feat/revamp_lean_review
branch
from
0a5fb49
to
be6f58a
Compare
- simplifications
eduard-dumitru
force-pushed
the
feat/revamp_lean_review
branch
from
be6f58a
to
99b8c7c
Compare
eduard-dumitru
force-pushed
the
feat/revamp_lean_review
branch
from
d031e64
to
3acb41c
Compare
- decommission WaitForStop
eduard-dumitru
force-pushed
the
feat/revamp_lean_review
branch
from
3acb41c
to
59fe065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP