simplifications after review

- decommission WaitForStop
UiPath · Nov 28, 2024 · d031e64 · d031e64
1 parent ce5c4a2
commit d031e64
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 37 deletions.
diff --git a/src/UiPath.CoreIpc/Config/IpcServer.cs b/src/UiPath.CoreIpc/Config/IpcServer.cs
@@ -9,7 +9,6 @@ public sealed class IpcServer : IpcBase, IAsyncDisposable
 
     private readonly object _lock = new();
     private readonly TaskCompletionSource<object?> _listening = new();
-    private readonly TaskCompletionSource<object?> _stopped = new();
     private readonly CancellationTokenSource _ctsActiveConnections = new();
 
     private bool _disposeStarted;
@@ -70,7 +69,6 @@ public Task WaitForStart()
         Start();
         return _accepter.StartedAccepting;
     }
-    public Task WaitForStop() => _stopped.Task;
 
     internal ILogger? CreateLogger(string category) => ServiceProvider.MaybeCreateLogger(category);
 
@@ -82,7 +80,6 @@ private void OnNewConnection(Stream network)
     private void OnNewConnectionError(Exception ex)
     {
         Trace.TraceError($"Failed to accept new connection. Ex: {ex}");
-        _stopped.TrySetException(ex);
     }
 
     internal RouterConfig CreateRouterConfig(IpcServer server) => RouterConfig.From(

diff --git a/src/UiPath.Ipc.Tests/Program.cs b/src/UiPath.Ipc.Tests/Program.cs
diff --git a/src/UiPath.Ipc.Tests/UiPath.Ipc.Tests.csproj b/src/UiPath.Ipc.Tests/UiPath.Ipc.Tests.csproj
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <OutputType>WinExe</OutputType>
     <TargetFrameworks>net6.0;net461</TargetFrameworks>
     <RootNamespace>UiPath.Ipc.Tests</RootNamespace>
     <NoWarn>$(NoWarn);1998</NoWarn>