Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate KML from waypoints.csv #23

Merged
merged 17 commits into from
Nov 28, 2023
Merged

Generate KML from waypoints.csv #23

merged 17 commits into from
Nov 28, 2023

Conversation

eshaan-mehta
Copy link
Contributor

No description provided.

Xierumeng
Xierumeng reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/waypoints_dict_to_kml.py Outdated Show resolved Hide resolved
path_2023.py Outdated Show resolved Hide resolved
path_2023.py Outdated Show resolved Hide resolved
tests/test_kml/test_kml_document.kml Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_kml.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_kml.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Please see previous unresolved comments as well. Also you should rebase branch on main/merge main into branch.

tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Please also rebase branch on main or merge main into branch.

modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
path_2023.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Nov 4, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Please rebase branch on main/merge main into branch to resolve conflicts.

tests/test_waypoints_dict_to_list.py Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Nov 5, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Please rebase branch on main/merge main to branch as I have asked before.

tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
@eshaan-mehta eshaan-mehta force-pushed the generate-kml-waypoint-csv branch from 90f9ebf to fc20b92 Compare November 7, 2023 02:56
Xierumeng
Xierumeng reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Copy the changes in path_2023.py to path_2024.py as well.

tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

path_2023.py Show resolved Hide resolved
path_2023.py Outdated Show resolved Hide resolved
path_2023.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

path_2023.py Outdated Show resolved Hide resolved
path_2024.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, very close to done!

path_2023.py Outdated Show resolved Hide resolved
path_2023.py Outdated Show resolved Hide resolved
path_2023.py Outdated Show resolved Hide resolved
path_2024.py Show resolved Hide resolved
Xierumeng
Xierumeng previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Xierumeng Xierumeng dismissed their stale review November 16, 2023 18:33

Merge conflict.

Xierumeng
Xierumeng reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
@eshaan-mehta eshaan-mehta force-pushed the generate-kml-waypoint-csv branch from 71caca7 to 1b3749c Compare November 25, 2023 21:54
Xierumeng
Xierumeng reviewed Nov 25, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
tests/test_waypoints_dict_to_list.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng reviewed Nov 26, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/waypoints_dict_to_list.py Show resolved Hide resolved
modules/waypoints_dict_to_list.py Outdated Show resolved Hide resolved
path_2023.py Outdated Show resolved Hide resolved
path_2023.py Outdated Show resolved Hide resolved
path_2024.py Outdated Show resolved Hide resolved
path_2024.py Outdated Show resolved Hide resolved
Xierumeng
Xierumeng approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@eshaan-mehta eshaan-mehta merged commit 12bd117 into main Nov 28, 2023
1 check passed
@eshaan-mehta eshaan-mehta deleted the generate-kml-waypoint-csv branch November 28, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xierumeng Xierumeng Xierumeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshaan-mehta @Xierumeng